fix: address review feedback on confluence extractor

- Paginate GetPageLabels to capture all labels (not just first page)
- Use time.RFC3339 for proper timezone handling in timestamps
- Tighten exclusion test to assert ENG space exists (not just absence of ARCHIVE)

Author: ravisuhag

plugins/extractors/confluence/client.go

@@ -148,15 +148,34 @@ func (c *Client) GetPages(ctx context.Context, spaceID string) ([]Page, error) {
 	return all, nil
 }
 
-// GetPageLabels returns labels for a page.
+// GetPageLabels returns all labels for a page, handling pagination.
 func (c *Client) GetPageLabels(ctx context.Context, pageID string) ([]Label, error) {
-	var resp struct {
-		Results []Label `json:"results"`
-	}
-	if err := c.get(ctx, "/api/v2/pages/"+pageID+"/labels", nil, &resp); err != nil {
-		return nil, fmt.Errorf("get labels for page %s: %w", pageID, err)
+	var all []Label
+	cursor := ""
+	for {
+		params := url.Values{}
+		params.Set("limit", "25")
+		if cursor != "" {
+			params.Set("cursor", cursor)
+		}
+
+		var resp struct {
+			Results []Label `json:"results"`
+			Links   struct {
+				Next string `json:"next"`
+			} `json:"_links"`
+		}
+		if err := c.get(ctx, "/api/v2/pages/"+pageID+"/labels", params, &resp); err != nil {
+			return nil, fmt.Errorf("get labels for page %s: %w", pageID, err)
+		}
+		all = append(all, resp.Results...)
+
+		cursor = parseCursor(resp.Links.Next)
+		if cursor == "" {
+			break
+		}
 	}
-	return resp.Results, nil
+	return all, nil
 }
 
 func (c *Client) get(ctx context.Context, path string, params url.Values, out any) error {

plugins/extractors/confluence/confluence.go

@@ -6,6 +6,7 @@ import (
 	"fmt"
 	"regexp"
 	"strings"
+	"time"
 
 	"github.com/raystack/meteor/models"
 	meteorv1beta1 "github.com/raystack/meteor/models/raystack/meteor/v1beta1"
@@ -150,8 +151,8 @@ func (e *Extractor) buildPageRecord(page Page, space Space, spaceURN string, lab
 		"space_key":  space.Key,
 		"status":     page.Status,
 		"version":    page.Version.Number,
-		"created_at": page.CreatedAt.Format("2006-01-02T15:04:05Z"),
-		"updated_at": page.Version.CreatedAt.Format("2006-01-02T15:04:05Z"),
+		"created_at": page.CreatedAt.UTC().Format(time.RFC3339),
+		"updated_at": page.Version.CreatedAt.UTC().Format(time.RFC3339),
 	}
 	if len(labelNames) > 0 {
 		props["labels"] = labelNames

plugins/extractors/confluence/confluence_test.go

@@ -147,12 +147,11 @@ func TestExtract(t *testing.T) {
 		require.NoError(t, err)
 
 		records := emitter.Get()
-		for _, r := range records {
-			props := r.Entity().GetProperties().AsMap()
-			if key, ok := props["space_key"]; ok {
-				assert.NotEqual(t, "ARCHIVE", key)
-			}
-		}
+		spaceRecords := findAllByType(records, "space")
+		require.Len(t, spaceRecords, 1)
+
+		props := spaceRecords[0].Entity().GetProperties().AsMap()
+		assert.Equal(t, "ENG", props["space_key"])
 	})
 }