test(cli): add tests for Init, Output, and Prompter

- Init adds completion, reference, version commands
- Version command not added without option
- Output/Prompter return fallback when context not set
- Fix nil context panic in Output/Prompter extractors

Author: ravisuhag

cli/cli.go

@@ -91,16 +91,20 @@ func versionCmd(name, ver, repo string) *cobra.Command {
 
 // Output extracts the shared printer from a command's context.
 func Output(cmd *cobra.Command) *printer.Output {
-	if ctx, ok := cmd.Context().Value(contextKey{}).(*cliContext); ok {
-		return ctx.output
+	if ctx := cmd.Context(); ctx != nil {
+		if cc, ok := ctx.Value(contextKey{}).(*cliContext); ok {
+			return cc.output
+		}
 	}
 	return printer.NewOutput(os.Stdout)
 }
 
 // Prompter extracts the shared prompter from a command's context.
 func Prompter(cmd *cobra.Command) prompt.Prompter {
-	if ctx, ok := cmd.Context().Value(contextKey{}).(*cliContext); ok {
-		return ctx.prompter
+	if ctx := cmd.Context(); ctx != nil {
+		if cc, ok := ctx.Value(contextKey{}).(*cliContext); ok {
+			return cc.prompter
+		}
 	}
 	return prompt.New()
 }

cli/cli_test.go

@@ -0,0 +1,111 @@
+package cli_test
+
+import (
+	"bytes"
+	"testing"
+
+	"github.com/raystack/salt/cli"
+	"github.com/spf13/cobra"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func newTestRoot() *cobra.Command {
+	return &cobra.Command{Use: "testcli", Short: "test app"}
+}
+
+func TestInit(t *testing.T) {
+	t.Run("adds completion command", func(t *testing.T) {
+		root := newTestRoot()
+		cli.Init(root)
+
+		found := false
+		for _, cmd := range root.Commands() {
+			if cmd.Name() == "completion" {
+				found = true
+			}
+		}
+		assert.True(t, found, "completion command should be added")
+	})
+
+	t.Run("adds reference command", func(t *testing.T) {
+		root := newTestRoot()
+		cli.Init(root)
+
+		found := false
+		for _, cmd := range root.Commands() {
+			if cmd.Name() == "reference" {
+				found = true
+			}
+		}
+		assert.True(t, found, "reference command should be added")
+	})
+
+	t.Run("adds version command when configured", func(t *testing.T) {
+		root := newTestRoot()
+		cli.Init(root, cli.Version("1.0.0", "raystack/test"))
+
+		found := false
+		for _, cmd := range root.Commands() {
+			if cmd.Name() == "version" {
+				found = true
+			}
+		}
+		assert.True(t, found, "version command should be added")
+	})
+
+	t.Run("no version command without option", func(t *testing.T) {
+		root := newTestRoot()
+		cli.Init(root)
+
+		for _, cmd := range root.Commands() {
+			assert.NotEqual(t, "version", cmd.Name(), "version command should not be added without option")
+		}
+	})
+
+	t.Run("version command prints version", func(t *testing.T) {
+		root := newTestRoot()
+		cli.Init(root, cli.Version("2.5.0", ""))
+
+		var buf bytes.Buffer
+		root.SetOut(&buf)
+		root.SetArgs([]string{"version"})
+		err := root.Execute()
+		require.NoError(t, err)
+	})
+}
+
+func TestOutput(t *testing.T) {
+	t.Run("returns output from context after Init", func(t *testing.T) {
+		root := newTestRoot()
+		cli.Init(root)
+
+		var out *bytes.Buffer
+		child := &cobra.Command{
+			Use: "child",
+			Run: func(cmd *cobra.Command, _ []string) {
+				o := cli.Output(cmd)
+				assert.NotNil(t, o)
+				out = &bytes.Buffer{}
+			},
+		}
+		root.AddCommand(child)
+		root.SetArgs([]string{"child"})
+		root.Execute()
+		assert.NotNil(t, out)
+	})
+
+	t.Run("returns fallback when no context", func(t *testing.T) {
+		cmd := &cobra.Command{Use: "bare"}
+		out := cli.Output(cmd)
+		assert.NotNil(t, out, "should return fallback output")
+	})
+}
+
+func TestPrompter(t *testing.T) {
+	t.Run("returns fallback when no context", func(t *testing.T) {
+		cmd := &cobra.Command{Use: "bare"}
+		p := cli.Prompter(cmd)
+		assert.NotNil(t, p, "should return fallback prompter")
+	})
+}