refactor(terminal): remove functions superseded by IOStreams

Remove IsTTY, IsColorDisabled, and Width from the terminal package —
these are now per-stream methods on IOStreams (IsStdoutTTY, ColorEnabled,
TerminalWidth). OpenBrowser uses isatty directly instead of IsTTY.

The terminal package retains OS-level utilities: IsCI, OpenBrowser,
Pager, IsUnderHomebrew, HasHomebrew.

Author: ravisuhag

cli/terminal/browser.go

@@ -6,42 +6,23 @@ import (
 	"strings"
 )
 
-// OpenBrowser opens the default web browser at the specified URL.
-//
-// Parameters:
-//   - goos: The operating system name (e.g., "darwin", "windows", or "linux").
-//   - url: The URL to open in the web browser.
-//
-// Returns:
-//   - An *exec.Cmd configured to open the URL. Note that you must call `cmd.Run()`
-//     or `cmd.Start()` on the returned command to execute it.
-//
-// Panics:
-//   - This function will panic if called without a TTY (e.g., not running in a terminal).
-func OpenBrowser(goos, url string) *exec.Cmd {
-	if !IsTTY() {
-		panic("OpenBrowser called without a TTY")
-	}
-
+// openBrowserCmd returns an exec.Cmd configured to open the URL.
+func openBrowserCmd(goos, url string) *exec.Cmd {
 	exe := "open"
 	var args []string
 
 	switch goos {
 	case "darwin":
-		// macOS: Use the "open" command to open the URL.
 		args = append(args, url)
 	case "windows":
-		// Windows: Use "cmd /c start" to open the URL.
 		exe, _ = exec.LookPath("cmd")
 		replacer := strings.NewReplacer("&", "^&")
 		args = append(args, "/c", "start", replacer.Replace(url))
 	default:
-		// Linux: Use "xdg-open" or fallback to "wslview" for WSL environments.
 		exe = linuxExe()
 		args = append(args, url)
 	}
 
-	// Create the command to open the browser and set stderr for error reporting.
 	cmd := exec.Command(exe, args...)
 	cmd.Stderr = os.Stderr
 	return cmd
@@ -50,14 +31,10 @@ func OpenBrowser(goos, url string) *exec.Cmd {
 // linuxExe determines the appropriate command to open a web browser on Linux.
 func linuxExe() string {
 	exe := "xdg-open"
-
-	_, err := exec.LookPath(exe)
-	if err != nil {
-		_, err := exec.LookPath("wslview")
-		if err == nil {
+	if _, err := exec.LookPath(exe); err != nil {
+		if _, err := exec.LookPath("wslview"); err == nil {
 			exe = "wslview"
 		}
 	}
-
 	return exe
 }

cli/terminal/term.go

@@ -2,41 +2,28 @@ package terminal
 
 import (
 	"os"
+	"os/exec"
 
 	"github.com/mattn/go-isatty"
-	"github.com/muesli/termenv"
-	"golang.org/x/term"
 )
 
-// IsTTY checks if the current output is a TTY (teletypewriter) or a Cygwin terminal.
-// This function is useful for determining if the program is running in a terminal
-// environment, which is important for features like colored output or interactive prompts.
-func IsTTY() bool {
-	return isatty.IsTerminal(os.Stdout.Fd()) || isatty.IsCygwinTerminal(os.Stdout.Fd())
-}
-
-// IsColorDisabled checks if color output is disabled based on the environment settings.
-// This function uses the `termenv` library to determine if the NO_COLOR environment
-// variable is set, which is a common way to disable colored output.
-func IsColorDisabled() bool {
-	return termenv.EnvNoColor()
-}
-
-// Width returns the terminal width in columns. Returns 80 if the width
-// cannot be determined (e.g. non-TTY, piped output).
-func Width() int {
-	w, _, err := term.GetSize(int(os.Stdout.Fd()))
-	if err == nil && w > 0 {
-		return w
-	}
-	return 80
-}
-
-// IsCI checks if the code is running in a Continuous Integration (CI) environment.
-// This function checks for common environment variables used by popular CI systems
-// like GitHub Actions, Travis CI, CircleCI, Jenkins, TeamCity, and others.
+// IsCI reports whether the process is running in a CI environment.
+// Checks common environment variables used by GitHub Actions, Travis CI,
+// CircleCI, Jenkins, TeamCity, and others.
 func IsCI() bool {
 	return os.Getenv("CI") != "" || // GitHub Actions, Travis CI, CircleCI, Cirrus CI, GitLab CI, AppVeyor, CodeShip, dsari
 		os.Getenv("BUILD_NUMBER") != "" || // Jenkins, TeamCity
 		os.Getenv("RUN_ID") != "" // TaskCluster, dsari
 }
+
+// OpenBrowser opens the default web browser at the specified URL.
+// The goos parameter should be runtime.GOOS (e.g. "darwin", "windows", "linux").
+//
+// Returns an *exec.Cmd — call cmd.Run() or cmd.Start() to execute it.
+// Panics if stdout is not a terminal.
+func OpenBrowser(goos, url string) *exec.Cmd {
+	if !isatty.IsTerminal(os.Stdout.Fd()) && !isatty.IsCygwinTerminal(os.Stdout.Fd()) {
+		panic("OpenBrowser called without a TTY")
+	}
+	return openBrowserCmd(goos, url)
+}