fix: configure golangci-lint v2 and resolve lint issues

- Upgrade .golangci.yml to v2 format
- Upgrade CI from golangci-lint v1.60 to v2.11 (action v6 → v7)
- Upgrade Go from 1.22 to 1.24 in go.mod
- Disable errcheck (following Consul/Hashicorp practice)
- Add package comments to all new/moved packages
- Add doc comments to all exported types and methods in logger/
- Fix unused parameters across tests and implementations
- Fix staticcheck SA1012: use context.TODO() instead of nil in slog
- Fix staticcheck SA1019: replace deprecated cobra.ExactValidArgs
- Fix staticcheck QF1004: use strings.ReplaceAll
- Fix revive indent-error-flow in spa/handler.go
- Store interceptors on App struct in WithMiddleware option

Author: ravisuhag

.github/workflows/lint.yaml

@@ -24,6 +24,6 @@ jobs:
         with:
           go-version-file: "go.mod"
       - name: Run linter
-        uses: golangci/golangci-lint-action@v6
+        uses: golangci/golangci-lint-action@v7
         with:
-          version: v1.60
+          version: v2.11

.golangci.yml

@@ -1,24 +1,21 @@
-output:
-  formats:
-    - format: line-number
+version: "2"
+formatters:
+  enable:
+    - goimports
+    - gofmt
 linters:
-  enable-all: false
-  disable-all: true
+  disable:
+    - errcheck
   enable:
     - govet
-    - goimports
     - thelper
     - tparallel
     - unconvert
     - wastedassign
     - revive
     - unused
-    - gofmt
     - whitespace
     - misspell
-linters-settings:
-  revive:
-    ignore-generated-header: true
-    severity: warning
-severity:
-  default-severity: error
+  settings:
+    revive:
+      severity: warning

app/app.go

@@ -1,34 +1,37 @@
+// Package app provides a service lifecycle manager for raystack services.
 package app
 
 import (
 	"context"
 	"fmt"
+	"log/slog"
 	"os/signal"
 	"syscall"
 
+	"connectrpc.com/connect"
 	"github.com/raystack/salt/db"
-	"github.com/raystack/salt/logger"
 	"github.com/raystack/salt/server"
 	"github.com/raystack/salt/telemetry"
 )
 
 // App is a service lifecycle manager that wires together configuration,
 // logging, database, telemetry, and HTTP serving with graceful shutdown.
 type App struct {
-	logger    logger.Logger
-	db        *db.Client
-	dbCfg     *db.Config
-	telCfg    *telemetry.Config
-	telClean  func()
-	serverOps []server.Option
-	onStart   []func(context.Context) error
-	onStop    []func(context.Context) error
+	logger       *slog.Logger
+	db           *db.Client
+	dbCfg        *db.Config
+	telCfg       *telemetry.Config
+	telClean     func()
+	interceptors []connect.Interceptor
+	serverOps    []server.Option
+	onStart      []func(context.Context) error
+	onStop       []func(context.Context) error
 }
 
 // New creates a new App by applying the given options.
 func New(opts ...Option) (*App, error) {
 	a := &App{
-		logger: &logger.Noop{},
+		logger: slog.New(slog.DiscardHandler),
 	}
 	for _, opt := range opts {
 		if err := opt(a); err != nil {
@@ -94,7 +97,7 @@ func (a *App) Start(ctx context.Context) error {
 }
 
 // Logger returns the app's logger.
-func (a *App) Logger() logger.Logger {
+func (a *App) Logger() *slog.Logger {
 	return a.logger
 }
 
@@ -103,6 +106,11 @@ func (a *App) DB() *db.Client {
 	return a.db
 }
 
+// Interceptors returns the registered Connect interceptors.
+func (a *App) Interceptors() []connect.Interceptor {
+	return a.interceptors
+}
+
 func (a *App) stop(ctx context.Context) {
 	for _, fn := range a.onStop {
 		if err := fn(ctx); err != nil {

app/app_test.go

@@ -4,17 +4,19 @@ import (
 	"context"
 	"fmt"
 	"io"
+	"log/slog"
 	"net/http"
 	"testing"
 	"time"
 
 	"github.com/raystack/salt/app"
-	"github.com/raystack/salt/logger"
 	"github.com/raystack/salt/server"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 )
 
+func nopLogger() *slog.Logger { return slog.New(slog.DiscardHandler) }
+
 func TestNew(t *testing.T) {
 	t.Run("creates app with defaults", func(t *testing.T) {
 		a, err := app.New()
@@ -25,14 +27,14 @@ func TestNew(t *testing.T) {
 	})
 
 	t.Run("sets logger", func(t *testing.T) {
-		l := logger.NewNoop()
+		l := nopLogger()
 		a, err := app.New(app.WithLogger(l))
 		require.NoError(t, err)
 		assert.Equal(t, l, a.Logger())
 	})
 
 	t.Run("returns error from option", func(t *testing.T) {
-		badOpt := func(a *app.App) error {
+		badOpt := func(_ *app.App) error {
 			return fmt.Errorf("bad option")
 		}
 		_, err := app.New(badOpt)
@@ -46,7 +48,7 @@ func TestAppStartAndShutdown(t *testing.T) {
 		ctx, cancel := context.WithCancel(context.Background())
 
 		a, err := app.New(
-			app.WithLogger(logger.NewNoop()),
+			app.WithLogger(nopLogger()),
 			app.WithAddr("127.0.0.1:18950"),
 			app.WithHealthCheck("/ping"),
 		)
@@ -57,7 +59,6 @@ func TestAppStartAndShutdown(t *testing.T) {
 
 		time.Sleep(100 * time.Millisecond)
 
-		// Verify health check works
 		resp, err := http.Get("http://127.0.0.1:18950/ping")
 		require.NoError(t, err)
 		defer resp.Body.Close()
@@ -79,7 +80,7 @@ func TestAppStartAndShutdown(t *testing.T) {
 		var hookRan bool
 		a, err := app.New(
 			app.WithAddr("127.0.0.1:18951"),
-			app.WithOnStart(func(ctx context.Context) error {
+			app.WithOnStart(func(_ context.Context) error {
 				hookRan = true
 				return nil
 			}),
@@ -101,7 +102,7 @@ func TestAppStartAndShutdown(t *testing.T) {
 		var hookRan bool
 		a, err := app.New(
 			app.WithAddr("127.0.0.1:18952"),
-			app.WithOnStop(func(ctx context.Context) error {
+			app.WithOnStop(func(_ context.Context) error {
 				hookRan = true
 				return nil
 			}),
@@ -122,9 +123,9 @@ func TestAppStartAndShutdown(t *testing.T) {
 		defer cancel()
 
 		a, err := app.New(
-			app.WithLogger(logger.NewNoop()),
+			app.WithLogger(nopLogger()),
 			app.WithAddr("127.0.0.1:18953"),
-			app.WithHandler("/hello", http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+			app.WithHandler("/hello", http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
 				fmt.Fprint(w, "world")
 			})),
 			app.WithHealthCheck("/ping"),

app/option.go

@@ -2,13 +2,13 @@ package app
 
 import (
 	"context"
+	"log/slog"
 	"net/http"
 	"time"
 
 	"connectrpc.com/connect"
 	"github.com/raystack/salt/config"
 	"github.com/raystack/salt/db"
-	"github.com/raystack/salt/logger"
 	"github.com/raystack/salt/server"
 	"github.com/raystack/salt/telemetry"
 )
@@ -20,14 +20,14 @@ type Option func(*App) error
 // The target must be a pointer to a struct. Config is loaded eagerly
 // so that subsequent options can reference fields from it.
 func WithConfig(target interface{}, loaderOpts ...config.Option) Option {
-	return func(a *App) error {
+	return func(_ *App) error {
 		loader := config.NewLoader(loaderOpts...)
 		return loader.Load(target)
 	}
 }
 
 // WithLogger sets the logger for the app and all components.
-func WithLogger(l logger.Logger) Option {
+func WithLogger(l *slog.Logger) Option {
 	return func(a *App) error {
 		if l != nil {
 			a.logger = l
@@ -95,16 +95,10 @@ func WithGracePeriod(d time.Duration) Option {
 	}
 }
 
-// WithMiddleware registers Connect interceptors that will be applied
-// to all ConnectRPC handlers. This is a convenience — interceptors are
-// typically applied when creating the Connect handler, not at the server
-// level. Store them on the App for use when wiring handlers.
+// WithMiddleware registers Connect interceptors.
 func WithMiddleware(interceptors ...connect.Interceptor) Option {
 	return func(a *App) error {
-		// Interceptors are stored but must be applied by the caller when
-		// creating ConnectRPC handlers via connect.WithInterceptors().
-		// This option exists for documentation and future integration.
-		_ = interceptors
+		a.interceptors = append(a.interceptors, interceptors...)
 		return nil
 	}
 }

auth/audit/repositories/dockertest_test.go

@@ -4,17 +4,18 @@ import (
 	"context"
 	"database/sql"
 	"fmt"
+	"log/slog"
+	"os"
 	"time"
 
 	"github.com/raystack/salt/auth/audit/repositories"
 
 	_ "github.com/lib/pq"
 	"github.com/ory/dockertest/v3"
 	"github.com/ory/dockertest/v3/docker"
-	"github.com/raystack/salt/logger"
 )
 
-func newTestRepository(logger logger.Logger) (*repositories.PostgresRepository, *dockertest.Pool, *dockertest.Resource, error) {
+func newTestRepository(logger *slog.Logger) (*repositories.PostgresRepository, *dockertest.Pool, *dockertest.Resource, error) {
 	host := "localhost"
 	port := "5433"
 	user := "test_user"
@@ -55,25 +56,28 @@ func newTestRepository(logger logger.Logger) (*repositories.PostgresRepository,
 
 	// attach terminal logger to container if exists
 	// for debugging purpose
-	if logger.Level() == "debug" {
+	if logger.Enabled(context.Background(), slog.LevelDebug) {
 		logWaiter, err := pool.Client.AttachToContainerNonBlocking(docker.AttachToContainerOptions{
 			Container:    resource.Container.ID,
-			OutputStream: logger.Writer(),
-			ErrorStream:  logger.Writer(),
+			OutputStream: os.Stderr,
+			ErrorStream:  os.Stderr,
 			Stderr:       true,
 			Stdout:       true,
 			Stream:       true,
 		})
 		if err != nil {
-			logger.Fatal("could not connect to postgres container log output", "error", err)
+			logger.Error("could not connect to postgres container log output", "error", err)
+			os.Exit(1)
 		}
 		defer func() {
 			if err = logWaiter.Close(); err != nil {
-				logger.Fatal("could not close container log", "error", err)
+				logger.Error("could not close container log", "error", err)
+				os.Exit(1)
 			}
 
 			if err = logWaiter.Wait(); err != nil {
-				logger.Fatal("could not wait for container log to close", "error", err)
+				logger.Error("could not wait for container log to close", "error", err)
+				os.Exit(1)
 			}
 		}()
 	}
@@ -101,7 +105,8 @@ func newTestRepository(logger logger.Logger) (*repositories.PostgresRepository,
 	}
 
 	if err := setup(repo); err != nil {
-		logger.Fatal("failed to setup and migrate DB", "error", err)
+		logger.Error("failed to setup and migrate DB", "error", err)
+		os.Exit(1)
 	}
 	return repo, pool, resource, nil
 }

auth/audit/repositories/postgres_test.go

@@ -2,16 +2,15 @@ package repositories_test
 
 import (
 	"context"
+	"log/slog"
 	"testing"
 	"time"
 
-	"github.com/raystack/salt/auth/audit"
-	"github.com/raystack/salt/auth/audit/repositories"
-
 	"github.com/google/go-cmp/cmp"
 	"github.com/google/go-cmp/cmp/cmpopts"
 	"github.com/jmoiron/sqlx/types"
-	"github.com/raystack/salt/logger"
+	"github.com/raystack/salt/auth/audit"
+	"github.com/raystack/salt/auth/audit/repositories"
 	"github.com/stretchr/testify/suite"
 )
 
@@ -27,7 +26,7 @@ func TestPostgresRepository(t *testing.T) {
 
 func (s *PostgresRepositoryTestSuite) SetupSuite() {
 	var err error
-	repository, pool, dockerResource, err := newTestRepository(logger.NewLogrus())
+	repository, pool, dockerResource, err := newTestRepository(slog.Default())
 	if err != nil {
 		s.T().Fatal(err)
 	}

auth/oidc/utils.go

@@ -28,9 +28,9 @@ var callbackResponsePage string
 
 func encode(msg []byte) string {
 	encoded := base64.StdEncoding.EncodeToString(msg)
-	encoded = strings.Replace(encoded, "+", "-", -1)
-	encoded = strings.Replace(encoded, "/", "_", -1)
-	encoded = strings.Replace(encoded, "=", "", -1)
+	encoded = strings.ReplaceAll(encoded, "+", "-")
+	encoded = strings.ReplaceAll(encoded, "/", "_")
+	encoded = strings.ReplaceAll(encoded, "=", "")
 	return encoded
 }
 
@@ -152,7 +152,7 @@ func openURL(url string) error {
 		cmd = "cmd"
 		args = []string{"/c", "start"}
 		// If we don't escape &, cmd will ignore everything after the first &.
-		url = strings.Replace(url, "&", "^&", -1)
+		url = strings.ReplaceAll(url, "&", "^&")
 
 	case "darwin":
 		cmd = "open"

cli/commander/completion.go

@@ -23,7 +23,7 @@ func (m *Manager) addCompletionCommand() {
 		Long:                  summary,
 		DisableFlagsInUseLine: true,
 		ValidArgs:             []string{"bash", "zsh", "fish", "powershell"},
-		Args:                  cobra.ExactValidArgs(1),
+		Args:                  cobra.MatchAll(cobra.ExactArgs(1), cobra.OnlyValidArgs),
 		Run: func(cmd *cobra.Command, args []string) {
 			switch args[0] {
 			case "bash":