chore: upgrade salt package (#181)

* chore: upgrade salt package

* chore: upgrade dependencies

* chore: module tidy

* chore: fix lint issues

* chore: fix lint issues

* fix: upgrade linter

* chore: golangci lint

* chore: make empty build folder for lint

Author: ravisuhag

.github/workflows/lint.yml

@@ -4,17 +4,17 @@ on: [push, pull_request]
 
 jobs:
   golangci:
-    name: "Lint Go"
+    name: "Lint"
     runs-on: "ubuntu-latest"
     steps:
-      - uses: actions/setup-go@v4
-        with:
-          go-version: "1.20"
-      - uses: actions/checkout@v3
+      - uses: actions/setup-go@v5
+      - uses: actions/checkout@v4
+      - name: Crete empty build directory
+        run: mkdir ui/build && touch ui/build/.gitkeep
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v3
+        uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.54
+          version: v1.64
 
   codeql:
     name: "Analyze with CodeQL"

.golangci.yaml

@@ -1,19 +1,13 @@
 run:
   timeout: 5m
-  skip-dirs:
-    - api/proto
-    - clients/java
-    - clients/js
-    - docs
-    - scripts
-    - ui
 output:
-  format: line-number
+  formats:
+    - format: colored-line-number
 linters:
   enable-all: false
   disable-all: true
   enable:
-    - vet
+    - govet
     - goimports
     - thelper
     - tparallel
@@ -29,6 +23,13 @@ linters-settings:
     ignore-generated-header: true
     severity: warning
 issues:
+  exclude-dirs:
+    - api/proto
+    - clients/java
+    - clients/js
+    - docs
+    - scripts
+    - ui
   fix: true
 severity:
   default-severity: error

cmd/check.go

@@ -7,8 +7,7 @@ import (
 	"os"
 
 	"github.com/MakeNowJust/heredoc"
-	"github.com/raystack/salt/printer"
-	"github.com/raystack/salt/term"
+	"github.com/raystack/salt/cli/printer"
 	stencilv1beta1 "github.com/raystack/stencil/proto/raystack/stencil/v1beta1"
 	"github.com/spf13/cobra"
 	"google.golang.org/grpc/status"
@@ -57,7 +56,7 @@ func checkSchemaCmd(cdk *CDK) *cobra.Command {
 			}
 
 			spinner.Stop()
-			fmt.Printf("\n%s Schema is compatible.\n", term.Green(term.SuccessIcon()))
+			fmt.Printf("\n%s Schema is compatible.\n", printer.Green(printer.Icon("success")))
 			return nil
 		},
 	}

cmd/client.go

@@ -2,10 +2,8 @@ package cmd
 
 import (
 	"context"
-	"errors"
 	"time"
 
-	"github.com/raystack/salt/cmdx"
 	"github.com/raystack/salt/config"
 	stencilv1beta1 "github.com/raystack/stencil/proto/raystack/stencil/v1beta1"
 	"github.com/spf13/cobra"
@@ -54,16 +52,13 @@ func createClient(cmd *cobra.Command, cdk *CDK) (stencilv1beta1.StencilServiceCl
 	return client, cancel, nil
 }
 
-func loadClientConfig(cmd *cobra.Command, cmdxConfig *cmdx.Config) (*ClientConfig, error) {
+func loadClientConfig(cmd *cobra.Command, cmdxConfig *config.Loader) (*ClientConfig, error) {
 	var clientConfig ClientConfig
 
 	if err := cmdxConfig.Load(
 		&clientConfig,
-		cmdx.WithFlags(cmd.Flags()),
 	); err != nil {
-		if !errors.Is(err, new(config.ConfigFileNotFoundError)) {
-			return nil, ErrClientConfigNotFound
-		}
+		return nil, err
 	}
 
 	return &clientConfig, nil

cmd/config.go

@@ -32,7 +32,7 @@ func configInitCommand(cdk *CDK) *cobra.Command {
 				return err
 			}
 
-			fmt.Printf("Config created: %v\n", cdk.Config.File())
+			fmt.Printf("Config created\n")
 			return nil
 		},
 	}
@@ -49,7 +49,7 @@ func configListCommand(cdk *CDK) *cobra.Command {
 			"group": "core",
 		},
 		RunE: func(cmd *cobra.Command, args []string) error {
-			data, err := cdk.Config.Read()
+			data, err := cdk.Config.View()
 			if err != nil {
 				return ErrClientConfigNotFound
 			}

cmd/create.go

@@ -7,8 +7,7 @@ import (
 	"os"
 
 	"github.com/MakeNowJust/heredoc"
-	"github.com/raystack/salt/printer"
-	"github.com/raystack/salt/term"
+	"github.com/raystack/salt/cli/printer"
 	stencilv1beta1 "github.com/raystack/stencil/proto/raystack/stencil/v1beta1"
 	"github.com/spf13/cobra"
 	"google.golang.org/grpc/codes"
@@ -52,7 +51,7 @@ func createSchemaCmd(cdk *CDK) *cobra.Command {
 			if err != nil {
 				errStatus := status.Convert(err)
 				if codes.AlreadyExists == errStatus.Code() {
-					fmt.Printf("\n%s Schema with id '%s' already exist.\n", term.FailureIcon(), args[0])
+					fmt.Printf("\n%s Schema with id '%s' already exist.\n", printer.Icon("failure"), args[0])
 					return nil
 				}
 				return errors.New(errStatus.Message())
@@ -61,7 +60,7 @@ func createSchemaCmd(cdk *CDK) *cobra.Command {
 			id := res.GetId()
 
 			spinner.Stop()
-			fmt.Printf("\n%s Created schema with id %s.\n", term.Green(term.SuccessIcon()), term.Cyan(id))
+			fmt.Printf("\n%s Created schema with id %s.\n", printer.Green(printer.Icon("success")), printer.Cyan(id))
 			return nil
 		},
 	}

cmd/delete.go

@@ -5,7 +5,7 @@ import (
 	"fmt"
 
 	"github.com/MakeNowJust/heredoc"
-	"github.com/raystack/salt/printer"
+	"github.com/raystack/salt/cli/printer"
 	stencilv1beta1 "github.com/raystack/stencil/proto/raystack/stencil/v1beta1"
 	"github.com/spf13/cobra"
 )

cmd/diff.go

@@ -6,7 +6,7 @@ import (
 	"fmt"
 
 	"github.com/MakeNowJust/heredoc"
-	"github.com/raystack/salt/printer"
+	"github.com/raystack/salt/cli/printer"
 	stencilv1beta1 "github.com/raystack/stencil/proto/raystack/stencil/v1beta1"
 	"github.com/spf13/cobra"
 	"github.com/yudai/gojsondiff"

cmd/download.go

@@ -5,8 +5,7 @@ import (
 	"os"
 
 	"github.com/MakeNowJust/heredoc"
-	"github.com/raystack/salt/printer"
-	"github.com/raystack/salt/term"
+	"github.com/raystack/salt/cli/printer"
 	"github.com/spf13/cobra"
 )
 
@@ -42,7 +41,7 @@ func downloadSchemaCmd(cdk *CDK) *cobra.Command {
 				return err
 			}
 
-			fmt.Printf("%s Schema successfully written to %s\n", term.Green(term.SuccessIcon()), output)
+			fmt.Printf("%s Schema successfully written to %s\n", printer.Green(printer.Icon("success")), output)
 			return nil
 		},
 	}

cmd/edit.go

@@ -5,7 +5,7 @@ import (
 	"fmt"
 
 	"github.com/MakeNowJust/heredoc"
-	"github.com/raystack/salt/printer"
+	"github.com/raystack/salt/cli/printer"
 	stencilv1beta1 "github.com/raystack/stencil/proto/raystack/stencil/v1beta1"
 	"github.com/spf13/cobra"
 )