Skip to content

Fix Fedora version check when VERSION_ID is decimal#2549

Merged
mislav merged 1 commit into
masterfrom
fedora-version-fix
Jun 30, 2025
Merged

Fix Fedora version check when VERSION_ID is decimal#2549
mislav merged 1 commit into
masterfrom
fedora-version-fix

Conversation

@mislav
Copy link
Copy Markdown
Member

@mislav mislav commented Jun 30, 2025

This fixes RHEL builds where VERSION_ID=7.9

Fixes #2546

This fixes RHEL builds where VERSION_ID=7.9
@mislav mislav merged commit 205bea6 into master Jun 30, 2025
6 checks passed
@mislav mislav deleted the fedora-version-fix branch June 30, 2025 15:16
@ylecuyer
Copy link
Copy Markdown

ylecuyer commented Jun 30, 2025

We learned the hard way we need to fix our ruby-build version in our CI/CD pipeline.

FTR we had the issue with oracle linux which presents itself as a fedora like 9.x
Symptoms were a decrease in performance around x3. I didn't dug to find the reason as I saw your fix, but most probably as the build script was failing early we were missing jit or -O3 in some flags that would explain the decrease in performance.

Copy link
Copy Markdown
Contributor

@pboling pboling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ruby-build throws invalid arithmetic operator for OS versions with floating-point

3 participants