Conversation
Commit f661b64 that restores `bin/jruby.sh` for all JRuby versions has an undesired effect on JRuby 9.3 when it pulls in jruby-launcher v2. Since JRuby 9.3 is EOL and won't get a fix for this, at least attempt to fix this in ruby-build since until recently JRuby 9.3 worked. The fix is that JRuby 9.3 (and only those versions) are not allowed to install jruby-launcher versions 2.0 or greater.
Contributor
|
Thanks @mislav, hopefully once the dust settles the new path will eliminate future problems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit f661b64 that restores
bin/jruby.shfor all JRuby versions has an undesired effect on JRuby 9.3 when it pulls in jruby-launcher v2. Since JRuby 9.3 is EOL and won't get a fix for this, at least attempt to fix this in ruby-build since until recently JRuby 9.3 worked.The fix is that JRuby 9.3 (and only those versions) is not allowed to install jruby-launcher versions 2.0 or greater.
I've tested this on macOS with openjdk v11 and jruby 9.3.15.0.
Fixes #2550
/cc @headius #2517