Adds the language filtering option on taxonomy to post types connections#36
Open
macharest wants to merge 1 commit into
Open
Adds the language filtering option on taxonomy to post types connections#36macharest wants to merge 1 commit into
macharest wants to merge 1 commit into
Conversation
Owner
|
Hm. I tried your initial query and in my setup I only get the corresponding posts in the translation. Did you translate the categories in the first place? I do have the categories translated and the posts are assigned to the translated categories. That way I only get the posts in the correct translation. In other words, I have a hard time testing whether your PR works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue where language filtering did not work on relationships between taxonomies and post types.
For example, the following query would return the posts associated to each category in the default language (english in my case), even if the categories are in french:
I expected to received the linked posts in the same language as my category.
My fix allows us to add the same wpmlLanguage filter on the child queries which will return the posts in the same language as the category:
This fix works for the relationship between posts and categories, but il also works with any relationships between custom taxonomies and custom post types.
In an ideal world, we would not have to do this, but this is the fix I came up with. Feel free to do what you want with it.