Run test suite when PR is created against develop branch. (#179)

Author: rcbjBlueMars

.github/workflows/tests.yml

@@ -7,8 +7,9 @@ on:
   # Terraform workflow (workflow_run on success), then the test-site deploy.
   push:
     branches: [ master, develop ]
+  # Run on PRs targeting master or develop (branches = the PR's base branch).
   pull_request:
-    branches: [ master ]
+    branches: [ master, develop ]
   workflow_dispatch:
 permissions:
   contents: read

tests/jwt_tools.js

@@ -89,7 +89,13 @@ async function getAccessToken(driver, client_id, client_secret, scope, pkce_enab
   var redirect_uri = By.id("redirect_uri");
   await driver.findElement(redirect_uri).clear();
   await driver.findElement(redirect_uri).sendKeys(baseUrl + "/callback");
-  await driver.findElement(btn_authorize).click();
+  // Scroll into view and JS-click: a native .click() can fail with "element
+  // click intercepted" because a hidden ".tooltiptext" span still occupies
+  // layout over the button. A JS click bypasses that interception check.
+  var btn_authorize_el = await driver.findElement(btn_authorize);
+  await driver.executeScript(
+    "arguments[0].scrollIntoView({ block: 'center' }); arguments[0].click();",
+    btn_authorize_el);
 
   // Login to Keycloak
   try {

tests/oauth2_device_authorization.js

@@ -57,7 +57,14 @@ async function requestDeviceAuthorization(driver, client_id, scope) {
   await driver.findElement(scopeField).sendKeys(scope);
 
   const authorizeBtn = By.css('input[type="submit"][value="Authorize"]');
-  await driver.findElement(authorizeBtn).click();
+  // Scroll into view and click via JS. A native .click() runs ChromeDriver's
+  // interception check, which fails here because a hidden ".tooltiptext" span
+  // still occupies layout over the button ("element click intercepted"). A JS
+  // click invokes the handler directly and bypasses that check.
+  const authorizeEl = await driver.findElement(authorizeBtn);
+  await driver.executeScript(
+    "arguments[0].scrollIntoView({ block: 'center' }); arguments[0].click();",
+    authorizeEl);
 
   // The device authorization response is shown on debugger2.html.
   await driver.wait(until.elementLocated(By.id("device_user_code")), waitTime);