protondrive: scope proxy auth cache by client headers#6
Closed
tdawe1 wants to merge 4 commits intorclone:masterfrom
Closed
protondrive: scope proxy auth cache by client headers#6tdawe1 wants to merge 4 commits intorclone:masterfrom
tdawe1 wants to merge 4 commits intorclone:masterfrom
Conversation
Align the Proton Drive client with the SDK-era API contract by adding Drive SDK version header support, v2 volume move endpoint support, and revision verification data for upload blocks. Also treat DeleteChildren code 2501 as idempotent stale-state success to avoid failing cleanup paths.
Separate cached auth state by app and Drive SDK headers so the proxy does not reuse tokens across incompatible Proton clients. This keeps SDK migration testing honest instead of hiding scope mismatches behind a username-only cache.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support the rclone Proton Drive backend update by fixing the proxy auth cache behavior used during SDK-era client identification.
This change is intentionally narrow. It does three things:
x-pm-appversion, andx-pm-drive-sdk-versioninstead of username aloneAuthCacherimplementations so external caches keep working as beforeweb-account@...identity no longer works on/auth/v4/infoWithout this, one client identity can reuse cached auth information created for another, which makes the proxy behavior inaccurate and can hide real upstream auth problems.
This PR is split from the underlying SDK plumbing and from the broader route/retry hardening work so the cache fix can be reviewed on its own merits.
Testing:
This PR should be reviewed on top of the companion
go-proton-apiSDK base compatibility PR.Companion base PR: #5