Skip to content

2 use a state state machine to switch between walking phases#13

Merged
rdesarz merged 3 commits into
mainfrom
2-use-a-state-state-machine-to-switch-between-walking-phases
Nov 17, 2025
Merged

2 use a state state machine to switch between walking phases#13
rdesarz merged 3 commits into
mainfrom
2-use-a-state-state-machine-to-switch-between-walking-phases

Conversation

@rdesarz
Copy link
Copy Markdown
Owner

@rdesarz rdesarz commented Nov 16, 2025

Add a state machine that detects the transition between each phase of the walk

@rdesarz rdesarz linked an issue Nov 16, 2025 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 16, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 71.42857% with 22 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
biped_walking_controller/plot.py 0.00% 16 Missing ⚠️
biped_walking_controller/preview_control.py 93.22% 4 Missing ⚠️
biped_walking_controller/simulation.py 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@rdesarz rdesarz marked this pull request as ready for review November 17, 2025 20:49
@rdesarz rdesarz force-pushed the 2-use-a-state-state-machine-to-switch-between-walking-phases branch from bc8fcb3 to 2e51ff6 Compare November 17, 2025 20:51
@rdesarz rdesarz merged commit 82f6cb5 into main Nov 17, 2025
10 checks passed
@chatgpt-codex-connector
Copy link
Copy Markdown

💡 Codex Review

def plot_contact_forces(
t: float,
force_rf: float,
force_lf: float,
states: WalkingState,

P1 Badge Update plot_contact_forces callers after new required arg

The updated signature of plot_contact_forces adds a required states argument with no default, but existing callers (e.g., examples/example_4_physics_simulation.py still call it with only t, force_rf, and force_lf) will now raise a TypeError: plot_contact_forces() missing 1 required positional argument: 'states' as soon as the example is run. Please either make states optional or adjust callers to pass the state sequence so the plotting code can execute.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@rdesarz rdesarz deleted the 2-use-a-state-state-machine-to-switch-between-walking-phases branch November 17, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use a state state machine to switch between walking phases

2 participants