Test#3
Open
jochenklar wants to merge 2 commits into
Open
Conversation
MyPyDavid
approved these changes
May 7, 2026
MyPyDavid
left a comment
MyPyDavid
left a comment
Member
There was a problem hiding this comment.
Yes nice, this is also how I would have thought to do it!
Member
|
Great. Having this test installation in CI is a great improvement. Tests (aparts from the config checks) are not planned? |
afuetterer
reviewed
May 28, 2026
| persist-credentials: false | ||
|
|
||
| - name: Set up Python | ||
| uses: actions/setup-python@v5 |
afuetterer
reviewed
May 28, 2026
| - name: Set up Python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: ${{ env.PYTHON_VERSION }} |
Member
There was a problem hiding this comment.
Testing one python version is enough here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a generic check-this-plugin-with-the-rdmo-app workflow. I created https://github.com/rdmorganiser/actions for this (Claude convinced me that https://github.com/rdmorganiser/.github is not the correct place for this, but I think one repo for all our actions is enough).
I worked on what to put where quite a bit and I think this is a good fit. What do you think?
I also added checks, which will be very temporary, I guess, since we need to combine this with the new plugin app soonish.