Improve email invitation#1609
Open
CalamityC wants to merge 4 commits into
Open
Conversation
…email_project_path (#1596)
MyPyDavid
reviewed
May 12, 2026
| settings.MULTISITE = True | ||
| settings.PROJECT_INVITE_USE_PROJECT_SITE = True | ||
|
|
||
| invite = Invite.objects.get(pk=1) |
Member
There was a problem hiding this comment.
No, wait. So before you were testing that when the foo-user from foo.com receives an invite for a Project of example.com that he receives the invite url for example.com, right?!
This invite = Invite.objects.get(pk=1) does not test for that :p
I meant that you can just do this instead of using get_or_create:
foo_site = Site.objects.get(domain='foo.com')
foo_user = get_user_model().objects.get(username='foo-user')
Collaborator
Author
There was a problem hiding this comment.
The test before failed. So I pushed a test that I think should pass.
I'll have a look and try your suggestion.
|
Coverage is 94.915% — 2.4.5/improve-email-invitation into 2.4.5/release. No base build found for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add PROJECT_INVITE_USE_PROJECT_SITE setting and use it in get_invite_email_project_path (#1596)
Description
Related issue: #1596
Motivation and Context
How has this been tested?
Locally
Screenshots (if appropriate)