From 4dd52cfe9b6f2da676ce9cff6504cd330769adb1 Mon Sep 17 00:00:00 2001 From: Claudia Malzer Date: Mon, 22 Jun 2026 12:09:06 +0200 Subject: [PATCH] restore missing constants to handle toggle switch of closed tasks --- .../js/project/components/areas/Dashboard.js | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/rdmo/projects/assets/js/project/components/areas/Dashboard.js b/rdmo/projects/assets/js/project/components/areas/Dashboard.js index 56241327c9..f6fd5d90b9 100644 --- a/rdmo/projects/assets/js/project/components/areas/Dashboard.js +++ b/rdmo/projects/assets/js/project/components/areas/Dashboard.js @@ -42,12 +42,16 @@ const Dashboard = () => { const activeStepIssue = stepIssues.find((issue) => !isClosed(issue)) - const visibleTaskIssues = issues - .filter((issue) => getTaskType(issue) === 'task' && (showClosedTasks || !isClosed(issue))) + // we need these 2 constants to not loose the toggle switch if all issues are closed (but not visible) + const taskIssues = issues.filter((issue) => getTaskType(issue) === 'task') + const recommendationIssues = issues.filter((issue) => getTaskType(issue) === 'recommendation') + + const visibleTaskIssues = taskIssues + .filter((issue) => showClosedTasks || !isClosed(issue)) .sort((a, b) => Number(isClosed(a)) - Number(isClosed(b))) - const visibleRecommendationIssues = issues - .filter((issue) => getTaskType(issue) === 'recommendation' && (showClosedRecommendations || !isClosed(issue))) + const visibleRecommendationIssues = recommendationIssues + .filter((issue) => showClosedRecommendations || !isClosed(issue)) .sort((a, b) => Number(isClosed(a)) - Number(isClosed(b))) const guidanceIssues = issues.filter((issue) => @@ -156,7 +160,7 @@ const Dashboard = () => { ) } { - visibleTaskIssues.length > 0 && ( + taskIssues.length > 0 && ( <>

{gettext('Tasks')}

{ ) } { - visibleRecommendationIssues.length > 0 && ( + recommendationIssues.length > 0 && ( <>

{gettext('Recommendations')}