Skip to content

BUG: toggle switch disappears when all tasks are closed #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CalamityC wants to merge 1 commit into
base: 3.0.0/release
Choose a base branch
from
+10 −6
Open

BUG: toggle switch disappears when all tasks are closed #1647

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions rdmo/projects/assets/js/project/components/areas/Dashboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,16 @@ const Dashboard = () => {

const activeStepIssue = stepIssues.find((issue) => !isClosed(issue))

const visibleTaskIssues = issues
.filter((issue) => getTaskType(issue) === 'task' && (showClosedTasks || !isClosed(issue)))
// we need these 2 constants to not loose the toggle switch if all issues are closed (but not visible)
const taskIssues = issues.filter((issue) => getTaskType(issue) === 'task')
const recommendationIssues = issues.filter((issue) => getTaskType(issue) === 'recommendation')

const visibleTaskIssues = taskIssues
.filter((issue) => showClosedTasks || !isClosed(issue))
.sort((a, b) => Number(isClosed(a)) - Number(isClosed(b)))

const visibleRecommendationIssues = issues
.filter((issue) => getTaskType(issue) === 'recommendation' && (showClosedRecommendations || !isClosed(issue)))
const visibleRecommendationIssues = recommendationIssues
.filter((issue) => showClosedRecommendations || !isClosed(issue))
.sort((a, b) => Number(isClosed(a)) - Number(isClosed(b)))

const guidanceIssues = issues.filter((issue) =>
Expand Down Expand Up @@ -156,7 +160,7 @@ const Dashboard = () => {
)
}
{
visibleTaskIssues.length > 0 && (
taskIssues.length > 0 && (
<>
<h2>{gettext('Tasks')}</h2>
<ShowClosedIssues
Expand All @@ -170,7 +174,7 @@ const Dashboard = () => {
)
}
{
visibleRecommendationIssues.length > 0 && (
recommendationIssues.length > 0 && (
<>
<h2>{gettext('Recommendations')}</h2>
<ShowClosedIssues
Expand Down
Loading