Send mail errors should be handled#1670
Draft
CalamityC wants to merge 2 commits into
Draft
Conversation
MyPyDavid
reviewed
Jul 8, 2026
| from django.core.mail import EmailMessage | ||
|
|
||
|
|
||
| class MailSendError(Exception): |
Member
There was a problem hiding this comment.
I'm not sure if the want to make our custom Exception for this, but if we want it then there would be a special place in rdmo/core/exceptions.py (
Line 1 in 9f48c2f
Collaborator
Author
There was a problem hiding this comment.
Agreed that a custom exception belongs in rdmo/core/exceptions.py, not in core/mail.py.
I want a specific MailSendError so the view/API layers can handle SMTP failures distinctly, but it should inherit RDMOException and live in the shared exceptions module.
|
coverage: 95.025% (-0.09%) from 95.118% — add-smtp-exception-handling into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #1668
Catch SMTP mail errors and surface validation messages