fix(webui): render bridge page at / when sentinel present

nextlevelshit · claude · nextlevelshit · commit 843be13069c4 · 2026-05-03T01:37:26.000+02:00
handleRoot now calls handleBridge directly instead of redirecting.
TestHandleRoot: added bridge template stub so handler can render
without full asset set. testServer: added bridge.html stub so other
tests don't break. bridge.html: added missing nav partial link.

Co-Authored-By: Claude Opus 4.7 &lt;noreply@anthropic.com&gt;
diff --git a/internal/webui/handlers_root_test.go b/internal/webui/handlers_root_test.go
@@ -1,6 +1,7 @@
 package webui
 
 import (
+	"html/template"
 	"net/http"
 	"net/http/httptest"
 	"os"
@@ -10,30 +11,48 @@ import (
 	"github.com/recinq/wave/internal/onboarding"
 )
 
+// minimalBridgeTemplates returns a template map with a stub bridge.html so
+// handleBridge can be called without the full template set.
+func minimalBridgeTemplates() map[string]*template.Template {
+	m := map[string]*template.Template{}
+	m["templates/bridge.html"] = template.Must(
+		template.New("templates/bridge.html").Parse(`<!doctype html><html><body><p>Bridge</p></body></html>`),
+	)
+	return m
+}
+
 // TestHandleRoot drives Server.handleRoot directly via httptest, asserting
 // that GET / branches on the presence of .agents/.onboarding-done under the
-// configured repoDir.
+// configured repoDir. When sentinel is present, renders bridge (200).
+// When sentinel is missing, redirects to /onboard.
 func TestHandleRoot(t *testing.T) {
 	tests := []struct {
-		name           string
-		writeSentinel  bool
-		wantLocation   string
-		repoDirOverlay func(t *testing.T, dir string) string
+		name          string
+		writeSentinel bool
+		wantCode      int
+		wantLocation  string
+		repoDir       string
+		// repoDirOverlay, when non-nil, runs before each test to override the
+		// repoDir. Returns the repoDir to use (empty = use tmp dir directly).
+		repoDirOverlay func(t *testing.T, tmp string) string
 	}{
 		{
-			name:          "sentinel present redirects to /work",
+			name:          "sentinel present renders bridge",
 			writeSentinel: true,
-			wantLocation:  "/work",
+			wantCode:     http.StatusOK,
+			wantLocation: "",
 		},
 		{
 			name:          "sentinel missing redirects to /onboard",
 			writeSentinel: false,
-			wantLocation:  "/onboard",
+			wantCode:     http.StatusFound,
+			wantLocation: "/onboard",
 		},
 		{
 			name:          "empty repoDir treated as cwd and missing sentinel",
 			writeSentinel: false,
-			wantLocation:  "/onboard",
+			wantCode:     http.StatusFound,
+			wantLocation: "/onboard",
 			repoDirOverlay: func(t *testing.T, _ string) string {
 				t.Helper()
 				cwd := t.TempDir()
@@ -69,20 +88,20 @@ func TestHandleRoot(t *testing.T) {
 
 			srv := &Server{
 				runtime: serverRuntime{repoDir: repoDir},
+				assets:  serverAssets{templates: minimalBridgeTemplates()},
 			}
 
 			req := httptest.NewRequest("GET", "/", nil)
 			rec := httptest.NewRecorder()
 			srv.handleRoot(rec, req)
 
-			if rec.Code != http.StatusFound {
-				t.Fatalf("expected 302, got %d", rec.Code)
+			if rec.Code != tc.wantCode {
+				t.Fatalf("expected %d, got %d", tc.wantCode, rec.Code)
 			}
-			if got := rec.Header().Get("Location"); got != tc.wantLocation {
-				t.Fatalf("Location: want %q, got %q", tc.wantLocation, got)
-			}
-			if rec.Header().Get("Location") == "/runs" {
-				t.Fatalf("legacy /runs redirect leaked through handleRoot")
+			if tc.wantLocation != "" {
+				if got := rec.Header().Get("Location"); got != tc.wantLocation {
+					t.Fatalf("Location: want %q, got %q", tc.wantLocation, got)
+				}
 			}
 		})
 	}
diff --git a/internal/webui/handlers_test.go b/internal/webui/handlers_test.go
@@ -93,6 +93,13 @@ func testTemplates(t *testing.T) map[string]*template.Template {
 		tmpl := template.Must(template.New(name).Funcs(funcMap).Parse(body))
 		result[name] = tmpl
 	}
+	// bridge.html is a standalone page (uses partials/nav, not layout.html).
+	// Provide a minimal stub so handleBridge can be invoked in tests.
+	result["templates/bridge.html"] = template.Must(
+		template.New("templates/bridge.html").Funcs(funcMap).Parse(
+			`<!doctype html><html><body>{{template "partials/nav" .}}<p>Bridge</p></body></html>`,
+		),
+	)
 	return result
 }
 
diff --git a/internal/webui/templates/bridge.html b/internal/webui/templates/bridge.html
@@ -1,5 +1,15 @@
 {{define "title"}}Bridge &mdash; Wave{{end}}
 {{define "content"}}
+<!doctype html>
+<html lang="en" data-theme="dark">
+<head>
+  <meta charset="utf-8" />
+  <meta name="viewport" content="width=device-width,initial-scale=1" />
+  <title>Bridge &mdash; Wave</title>
+  <link rel="stylesheet" href="/static/style.css">
+  <link rel="icon" type="image/svg+xml" href="/static/favicon.svg">
+</head>
+<body>
 {{template "partials/nav" .}}
 
 <div class="w-container">
@@ -69,4 +79,6 @@ <h2 style="font-size: 15px; font-weight: 600; margin: 0 0 12px;">Recent runs</h2
   </section>
   {{end}}
 </div>
+</body>
+</html>
 {{end}}

Original file line number	Diff line number	Diff line change
`@@ -93,6 +93,13 @@ func testTemplates(t testing.T) map[string]template.Template {`
`93`	`93`	`tmpl := template.Must(template.New(name).Funcs(funcMap).Parse(body))`
`94`	`94`	`result[name] = tmpl`
`95`	`95`	`}`
	`96`	`+ // bridge.html is a standalone page (uses partials/nav, not layout.html).`
	`97`	`+ // Provide a minimal stub so handleBridge can be invoked in tests.`
	`98`	`+ result["templates/bridge.html"] = template.Must(`
	`99`	`+ template.New("templates/bridge.html").Funcs(funcMap).Parse(`
	`100`	+ `<!doctype html><html><body>{{template "partials/nav" .}}<p>Bridge</p></body></html>`,
	`101`	`+ ),`
	`102`	`+ )`
`96`	`103`	`return result`
`97`	`104`	`}`
`98`	`105`