Skip to content

fix: use scrollIntoParentView to prevent page scroll #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
afc163 merged 2 commits into from
Nov 25, 2025
+11 −18
Merged

fix: use scrollIntoParentView to prevent page scroll #633

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b063ff
fix: use scrollIntoParentView to prevent page scroll
tuzixiangs Nov 22, 2025
c58a090
fix: align scroll behavior and tests to prevent page scroll and jsdom…
tuzixiangs Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/OptionList/Column.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import pickAttrs from '@rc-component/util/lib/pickAttrs';
import type { DefaultOptionType, SingleValueType } from '../Cascader';
import CascaderContext from '../context';
import { SEARCH_MARK } from '../hooks/useSearchOptions';
import { isLeaf, toPathKey } from '../utils/commonUtil';
import { isLeaf, scrollIntoParentView, toPathKey } from '../utils/commonUtil';
import Checkbox from './Checkbox';

export const FIX_LABEL = '__cascader_fix_label__';
Expand Down Expand Up @@ -110,10 +110,7 @@ export default function Column<OptionType extends DefaultOptionType = DefaultOpt
const activeElement = menuRef.current.querySelector<HTMLElement>(selector);

if (activeElement) {
activeElement.scrollIntoView({
block: 'nearest',
inline: 'nearest',
});
scrollIntoParentView(activeElement);
Comment thread
tuzixiangs marked this conversation as resolved.
}
}
}, [activeValue, menuItemPrefixCls]);
Expand Down
Loading