Skip to content

Commit 815b3a5

Browse files
committed
chore: address standardization review comments
1 parent 32db381 commit 815b3a5

2 files changed

Lines changed: 16 additions & 5 deletions

File tree

.github/workflows/surge-preview.yml

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,23 @@ jobs:
2222
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0
2323
with:
2424
persist-credentials: false
25+
- name: Check Surge token
26+
id: surge-token
27+
env:
28+
SURGE_TOKEN: ${{ secrets.SURGE_TOKEN }}
29+
run: |
30+
if [ -n "$SURGE_TOKEN" ]; then
31+
echo "enabled=true" >> "$GITHUB_OUTPUT"
32+
else
33+
echo "enabled=false" >> "$GITHUB_OUTPUT"
34+
fi
2535
- name: Build preview
26-
if: ${{ secrets.SURGE_TOKEN != '' }}
36+
if: ${{ steps.surge-token.outputs.enabled == 'true' }}
2737
run: |
2838
npm install
2939
npm run build
3040
- uses: afc163/surge-preview@bf90a5a86111f6311ca42f0a5a0f80fb0fb03cec
31-
if: ${{ secrets.SURGE_TOKEN != '' }}
41+
if: ${{ steps.surge-token.outputs.enabled == 'true' }}
3242
env:
3343
SURGE_TOKEN: ${{ secrets.SURGE_TOKEN }}
3444
with:
@@ -38,5 +48,5 @@ jobs:
3848
failOnError: false
3949
setCommitStatus: false
4050
- name: Skip Surge preview
41-
if: ${{ secrets.SURGE_TOKEN == '' }}
51+
if: ${{ steps.surge-token.outputs.enabled != 'true' }}
4252
run: echo "SURGE_TOKEN is not configured; skip Surge preview."

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
"build": "npm run docs:build",
3131
"compile": "father build && lessc assets/index.less assets/index.css && lessc assets/bootstrap.less assets/bootstrap.css",
3232
"coverage": "rc-test --coverage",
33-
"deploy": "npm run docs:build && npm run docs:deploy",
33+
"deploy": "npm run docs:build:gh-pages && npm run docs:deploy",
3434
"docs:build": "dumi build",
3535
"docs:deploy": "gh-pages -d docs-dist",
3636
"lint": "eslint src/ --ext .ts,.tsx,.jsx,.js,.md",
@@ -40,7 +40,8 @@
4040
"prettier": "prettier --write --ignore-unknown .",
4141
"start": "dumi dev",
4242
"test": "rc-test",
43-
"tsc": "tsc --noEmit"
43+
"tsc": "tsc --noEmit",
44+
"docs:build:gh-pages": "GH_PAGES=1 npm run docs:build"
4445
},
4546
"lint-staged": {
4647
"**/*.{js,jsx,tsx,ts,md,json}": [

0 commit comments

Comments
 (0)