-
-
Notifications
You must be signed in to change notification settings - Fork 107
chore: update maintenance dependencies #620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
c1e8680
chore: update maintenance dependencies
afc163 2c4389d
fix: align TypeScript and ESLint compatibility
afc163 a576840
chore: use testing-library dom events
afc163 bcfdf93
test: keep react testing event behavior
afc163 ae5ecfe
chore: address review comments
afc163 f9a191e
fix: keep compatible eslint export rule
afc163 049752f
chore: preserve local eslint rule overrides
afc163 68b689d
chore: remove react type compatibility shim
afc163 f374a26
docs: use ut install for local setup
afc163 1920e5f
chore: restore vercel install command
afc163 9654511
chore: align maintenance dependencies
afc163 aaad5cd
fix: preserve React peer dependency range
afc163 dd5861f
docs: use npm install in README
afc163 e60c026
chore: remove redundant strict tsconfig flags
afc163 cbceea0
chore: remove manual global test declarations
afc163 cb84e0b
chore: migrate to native eslint flat config
afc163 8f953d5
chore: address review comments
afc163 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| import { FlatCompat } from '@eslint/eslintrc'; | ||
| import js from '@eslint/js'; | ||
| import tsEslintPlugin from '@typescript-eslint/eslint-plugin'; | ||
| import { createRequire } from 'node:module'; | ||
| import path from 'node:path'; | ||
| import { fileURLToPath } from 'node:url'; | ||
|
|
||
| const __filename = fileURLToPath(import.meta.url); | ||
| const __dirname = path.dirname(__filename); | ||
| const require = createRequire(import.meta.url); | ||
|
|
||
| const compat = new FlatCompat({ | ||
| baseDirectory: __dirname, | ||
| recommendedConfig: js.configs.recommended, | ||
| allConfig: js.configs.all, | ||
| }); | ||
|
|
||
| const legacyConfig = require('./.eslintrc.js'); | ||
| const recommendedTsRulesConfig = tsEslintPlugin.configs.recommended; | ||
| const recommendedTsRulesObject = Array.isArray(recommendedTsRulesConfig) | ||
| ? recommendedTsRulesConfig.reduce( | ||
| (rules, config) => ({ ...rules, ...(config.rules || {}) }), | ||
| {}, | ||
| ) | ||
| : recommendedTsRulesConfig?.rules || {}; | ||
| const recommendedTsRules = new Set(Object.keys(recommendedTsRulesObject)); | ||
|
|
||
| function hasCurrentTsRule(ruleName) { | ||
| const tsRuleName = ruleName.replace('@typescript-eslint/', ''); | ||
| return Boolean(tsEslintPlugin.rules[tsRuleName]); | ||
| } | ||
| const localTsRules = new Set( | ||
| Object.keys(legacyConfig.rules || {}).filter( | ||
| ruleName => | ||
| ruleName.startsWith('@typescript-eslint/') && hasCurrentTsRule(ruleName), | ||
| ), | ||
| ); | ||
|
|
||
| const noopRule = { | ||
| meta: { type: 'problem', docs: {}, schema: [] }, | ||
| create: () => ({}), | ||
| }; | ||
|
|
||
| function normalizeConfig(config) { | ||
| const next = { ...config }; | ||
|
|
||
| if (next.plugins?.['@typescript-eslint']) { | ||
| next.plugins = { ...next.plugins }; | ||
| delete next.plugins['@typescript-eslint']; | ||
| } | ||
|
|
||
| if (next.rules) { | ||
| next.rules = Object.fromEntries( | ||
| Object.entries(next.rules).filter(([ruleName]) => { | ||
| if (ruleName.startsWith('@babel/')) { | ||
| return false; | ||
| } | ||
| if (!ruleName.startsWith('@typescript-eslint/')) { | ||
| return true; | ||
| } | ||
| return recommendedTsRules.has(ruleName) || localTsRules.has(ruleName); | ||
| }), | ||
| ); | ||
| } | ||
|
|
||
| return next; | ||
| } | ||
|
|
||
| export default [ | ||
| { | ||
| ignores: [ | ||
| 'node_modules/', | ||
| 'coverage/', | ||
| 'es/', | ||
| 'lib/', | ||
| 'dist/', | ||
| 'docs-dist/', | ||
| '.dumi/', | ||
| '.doc/', | ||
| '.vercel/', | ||
| '.eslintrc.js', | ||
| 'src/index.d.ts', | ||
| ], | ||
| }, | ||
| { | ||
| plugins: { | ||
| '@typescript-eslint': { | ||
| ...tsEslintPlugin, | ||
| rules: { | ||
| ...tsEslintPlugin.rules, | ||
| 'consistent-type-exports': noopRule, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| ...compat.config(legacyConfig).map(normalizeConfig), | ||
| { | ||
| rules: { | ||
| '@typescript-eslint/no-empty-object-type': 'off', | ||
| '@typescript-eslint/no-unsafe-function-type': 'off', | ||
| '@typescript-eslint/no-unused-vars': 'off', | ||
| }, | ||
| }, | ||
| ]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| /// <reference types="jest" /> | ||
| /// <reference types="node" /> | ||
| /// <reference types="react" /> | ||
| /// <reference types="react-dom" /> | ||
| /// <reference types="@testing-library/jest-dom" /> | ||
|
|
||
| declare module '*.css'; | ||
| declare module '*.less'; | ||
| declare module 'jsonp'; | ||
|
|
||
| declare namespace JSX { | ||
| type Element = React.JSX.Element; | ||
| interface ElementClass extends React.JSX.ElementClass {} | ||
| interface ElementAttributesProperty | ||
| extends React.JSX.ElementAttributesProperty {} | ||
| interface ElementChildrenAttribute | ||
| extends React.JSX.ElementChildrenAttribute {} | ||
| type LibraryManagedAttributes<C, P> = React.JSX.LibraryManagedAttributes< | ||
| C, | ||
| P | ||
| >; | ||
| interface IntrinsicAttributes extends React.JSX.IntrinsicAttributes {} | ||
| interface IntrinsicClassAttributes<T> extends React.JSX | ||
| .IntrinsicClassAttributes<T> {} | ||
| interface IntrinsicElements extends React.JSX.IntrinsicElements {} | ||
| } | ||
|
|
||
| declare namespace jest { | ||
| interface Matchers<R> { | ||
| lastCalledWith(...expected: unknown[]): R; | ||
| nthCalledWith(nthCall: number, ...expected: unknown[]): R; | ||
| toBeCalled(): R; | ||
| toBeCalledTimes(expected: number): R; | ||
| toBeCalledWith(...expected: unknown[]): R; | ||
| } | ||
| } | ||
|
|
||
| declare const vi: { | ||
| fn: <T extends (...args: any[]) => any = (...args: any[]) => any>( | ||
| implementation?: T, | ||
| ) => jest.MockedFunction<T>; | ||
| mock: ( | ||
| moduleName: string, | ||
| factory?: (importOriginal: <T>() => Promise<T>) => unknown, | ||
| ) => void; | ||
| spyOn: typeof jest.spyOn; | ||
| useFakeTimers: () => void; | ||
| useRealTimers: () => void; | ||
| advanceTimersByTime: (msToRun: number) => void; | ||
| clearAllTimers: () => void; | ||
| runAllTimers: () => void; | ||
| importActual: <T>(moduleName: string) => Promise<T>; | ||
| clearAllMocks: () => void; | ||
| resetAllMocks: () => void; | ||
| restoreAllMocks: () => void; | ||
| }; | ||
|
|
||
| declare module 'moment/locale/zh-cn'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,30 @@ | ||
| { | ||
| "compilerOptions": { | ||
| "target": "esnext", | ||
| "moduleResolution": "node", | ||
| "baseUrl": "./", | ||
| "moduleResolution": "bundler", | ||
| "jsx": "preserve", | ||
| "declaration": true, | ||
| "skipLibCheck": true, | ||
| "esModuleInterop": true, | ||
| "paths": { | ||
| "@/*": ["src/*"], | ||
| "@@/*": ["src/.umi/*"], | ||
| "@rc-component/drawer": ["src/index.ts"] | ||
| "@/*": ["./src/*"], | ||
| "@@/*": ["./src/.umi/*"], | ||
| "@rc-component/drawer": ["./src/index.ts"] | ||
| }, | ||
| "ignoreDeprecations": "5.0" | ||
| "noImplicitAny": false, | ||
| "strictNullChecks": false, | ||
| "strictPropertyInitialization": false, | ||
| "strictFunctionTypes": false, | ||
| "strict": false, | ||
| "noImplicitThis": false, | ||
| "strictBindCallApply": false, | ||
|
coderabbitai[bot] marked this conversation as resolved.
Outdated
|
||
| "module": "ESNext" | ||
| }, | ||
| "include": [".dumirc.ts", ".fatherrc.ts", "**/*.ts", "**/*.tsx"] | ||
| "include": [ | ||
| "global.d.ts", | ||
| ".dumirc.ts", | ||
| ".fatherrc.ts", | ||
| "**/*.ts", | ||
| "**/*.tsx" | ||
| ] | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.