chore: standardize rc footer config#145
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 59 minutes Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable usage-based reviews in Billing to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information, and refer to the rate limits docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (13)
Walkthrough将包名从 ChangesFooter 包名迁移与站点配置
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
React Doctor found no issues. 🎉 Reviewed by React Doctor for commit |
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
✅ Preview is ready!
↩️ Previous: ⚡️ 🤖 Powered by surge-preview |
|||||||||||||||
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the package from rc-footer to the scoped @rc-component/footer package, updating configuration files, examples, documentation, and build scripts accordingly. The output directory has been renamed from .doc to docs-dist, and support for Vercel deployment has been added. Feedback on these changes highlights two issues: first, the newly introduced rc-np package should be added to devDependencies to ensure reproducible builds; second, a specific path mapping for assets should be added to tsconfig.json to prevent TypeScript from incorrectly searching for assets inside the src directory.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
package.json (1)
40-40: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win把 lint 范围扩到这次实际修改的示例和配置文件。
Line 40 现在只检查
src/，但本 PR 同时修改了docs/examples/*和.dumirc.ts。这样npm run lint通过时，仍然发现不了这些改动里的 ESLint 问题。建议修改
- "lint": "eslint src/ --ext .ts,.tsx,.jsx,.js,.md", + "lint": "eslint src docs/examples .dumirc.ts --ext .ts,.tsx,.jsx,.js,.md",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@package.json` at line 40, The lint script in package.json only covers src/, so it misses ESLint issues in the actual files changed by this PR. Update the lint command to include the docs/examples/* files and the .dumirc.ts config file alongside the existing src/ and markdown targets, keeping the command tied to the package.json lint script.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/main.yml:
- Around line 14-15: The reusable workflow call in main.yml is over-permissive
because it uses secrets: inherit for the external workflow
react-component/rc-test/.github/workflows/test-utoo.yml. Update the workflow
invocation to stop inheriting all secrets and instead pass only the required
secret explicitly, keeping CODECOV_TOKEN as the sole declared secret for this
call.
In `@README.md`:
- Around line 87-92: The API table still describes the `Column` props using
“footer” in the `className` and `style` descriptions, which looks copied from
the wrong section. Update the wording in the README table for `Column` so the
`className` and `style` entries correctly describe the `Column` component rather
than `footer`, and keep the rest of the `ColumnItem`/`Column` documentation
consistent.
---
Nitpick comments:
In `@package.json`:
- Line 40: The lint script in package.json only covers src/, so it misses ESLint
issues in the actual files changed by this PR. Update the lint command to
include the docs/examples/* files and the .dumirc.ts config file alongside the
existing src/ and markdown targets, keeping the command tied to the package.json
lint script.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 37b752ef-0632-483a-be87-f67e1380f555
📒 Files selected for processing (17)
.dumirc.ts.github/FUNDING.yml.github/workflows/codeql.yml.github/workflows/main.yml.github/workflows/react-doctor.yml.github/workflows/surge-preview.yml.github/workflows/test.yml.gitignore.prettierignoreREADME.mddocs/examples/rows.tsxdocs/examples/simple.tsxdocs/examples/theme.tsxdocs/index.mdpackage.jsontsconfig.jsonvercel.json
💤 Files with no reviewable changes (1)
- .github/workflows/test.yml
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
=======================================
Coverage 97.77% 97.77%
=======================================
Files 2 2
Lines 45 45
Branches 25 25
=======================================
Hits 44 44
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Deployment failed with the following error: Learn More: https://vercel.com/afc163s-projects?upgradeToPro=build-rate-limit |
2 participants
Summary
Standardize this rc-component repository as part of the Ant Design rc-component maintenance sweep.
Tracking issue: ant-design/ant-design#58514
Scope
types: "./es/index.d.ts", publishConfig, and release flow through@rc-component/np.react-component/rc-test/.github/workflows/test-utoo.yml@mainworkflow, React Doctor, Codecov, CodeQL, updated GitHub Actions versions, and guarded Surge preview fallback.docs-distoutput and remove legacynow-build/ Cloudflare Pages residue.Notes
secrets: inheritis kept untilreact-component/rc-test#176is merged, then it can be narrowed to explicitCODECOV_TOKENforwarding.