chore: address review comments

Author: afc163

eslint.config.mjs

@@ -1,12 +1,16 @@
 import js from '@eslint/js';
 import { defineConfig } from 'eslint/config';
+import { dirname } from 'node:path';
+import { fileURLToPath } from 'node:url';
 import prettier from 'eslint-config-prettier';
 import jest from 'eslint-plugin-jest';
 import react from 'eslint-plugin-react';
 import reactHooks from 'eslint-plugin-react-hooks';
 import globals from 'globals';
 import tseslint from 'typescript-eslint';
 
+const tsconfigRootDir = dirname(fileURLToPath(import.meta.url));
+
 export default defineConfig([
   {
     plugins: {
@@ -15,7 +19,7 @@ export default defineConfig([
   },
   {
     linterOptions: {
-      reportUnusedDisableDirectives: 'off',
+      reportUnusedDisableDirectives: 'warn',
     },
   },
   {
@@ -26,10 +30,10 @@ export default defineConfig([
       'lib/',
       'dist/',
       'docs-dist/',
+      '.docs-dist/',
       '.dumi/',
       '.doc/',
       '.vercel/',
-      'src/index.d.ts',
     ],
   },
   {
@@ -88,7 +92,7 @@ export default defineConfig([
     languageOptions: {
       parserOptions: {
         projectService: true,
-        tsconfigRootDir: import.meta.dirname,
+        tsconfigRootDir,
       },
     },
   },

src/hooks/useDomMotionEvents.ts

@@ -6,19 +6,22 @@ import { animationEndName, transitionEndName } from '../util/motion';
 
 export default (
   onInternalMotionEnd: (event: MotionEvent) => void,
-): [(element: HTMLElement) => void, (element: HTMLElement) => void] => {
-  const cacheElementRef = useRef<HTMLElement | undefined>(undefined);
+): [
+  (element: HTMLElement | null) => void,
+  (element: HTMLElement | null) => void,
+] => {
+  const cacheElementRef = useRef<HTMLElement | null>(null);
 
   // Remove events
-  function removeMotionEvents(element: HTMLElement) {
+  function removeMotionEvents(element: HTMLElement | null) {
     if (element) {
       element.removeEventListener(transitionEndName, onInternalMotionEnd);
       element.removeEventListener(animationEndName, onInternalMotionEnd);
     }
   }
 
   // Patch events
-  function patchMotionEvents(element: HTMLElement) {
+  function patchMotionEvents(element: HTMLElement | null) {
     if (cacheElementRef.current && cacheElementRef.current !== element) {
       removeMotionEvents(cacheElementRef.current);
     }

tests/CSSMotion.spec.tsx

@@ -855,7 +855,13 @@ describe('CSSMotion', () => {
   });
 
   describe('strict mode', () => {
+    let hasFindDOMNode = false;
+    let originalFindDOMNode: unknown;
+
     beforeEach(() => {
+      hasFindDOMNode = 'findDOMNode' in ReactDOM;
+      originalFindDOMNode = (ReactDOM as any).findDOMNode;
+
       if (!('findDOMNode' in ReactDOM)) {
         Object.defineProperty(ReactDOM, 'findDOMNode', {
           value: jest.fn(),
@@ -867,7 +873,17 @@ describe('CSSMotion', () => {
     });
 
     afterEach(() => {
-      jest.resetAllMocks();
+      jest.restoreAllMocks();
+
+      if (hasFindDOMNode) {
+        Object.defineProperty(ReactDOM, 'findDOMNode', {
+          value: originalFindDOMNode,
+          writable: true,
+          configurable: true,
+        });
+      } else {
+        delete (ReactDOM as any).findDOMNode;
+      }
     });
 
     it('not crash when no refs are passed', () => {