Skip to content

Commit 3ffd566

Browse files
QDyanbingQDyanbing
authored
fix: set option list virtual prefix (#1241)
1 parent a264f26 commit 3ffd566

7 files changed

Lines changed: 41 additions & 36 deletions

File tree

‎src/OptionList.tsx‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -323,6 +323,7 @@ const OptionList: React.ForwardRefRenderFunction<RefOptionListProps, {}> = (_, r
323323
</div>
324324
)}
325325
<List<FlattenOptionData<BaseOptionType>>
326+
prefixCls={`${prefixCls}-dropdown-list`}
326327
itemKey="key"
327328
ref={listRef}
328329
data={memoFlattenOptions}

‎tests/Accessibility.test.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ describe('Select.Accessibility', () => {
193193
}
194194
});
195195

196-
const rcVirtual = document.querySelector('.rc-virtual-list-holder-inner');
196+
const rcVirtual = document.querySelector('.rc-select-dropdown-list-holder-inner');
197197
expect(rcVirtual).not.toHaveAttribute('role');
198198
const rcOptionItem = rcVirtual.querySelectorAll('.rc-select-item-option');
199199

‎tests/OptionList.test.tsx‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -560,7 +560,9 @@ describe('OptionList', () => {
560560
const { container } = render(<Select open showScrollBar options={options} />);
561561

562562
await waitFor(() => {
563-
const scrollbarElement = container.querySelector('.rc-virtual-list-scrollbar-visible');
563+
const scrollbarElement = container.querySelector(
564+
'.rc-select-dropdown-list-scrollbar-visible',
565+
);
564566
expect(scrollbarElement).not.toBeNull();
565567
});
566568
});
@@ -573,7 +575,9 @@ describe('OptionList', () => {
573575
const { container } = render(<Select open showScrollBar={false} options={options} />);
574576

575577
await waitFor(() => {
576-
const scrollbarElement = container.querySelector('.rc-virtual-list-scrollbar-visible');
578+
const scrollbarElement = container.querySelector(
579+
'.rc-select-dropdown-list-scrollbar-visible',
580+
);
577581
expect(scrollbarElement).toBeNull();
578582
});
579583
});

‎tests/Select.test.tsx‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -180,9 +180,9 @@ describe('Select.Basic', () => {
180180
);
181181

182182
// these generate the same snapshots
183-
expect(containerFirst.querySelector('.rc-virtual-list')).toMatchSnapshot();
184-
expect(containerSecond.querySelector('.rc-virtual-list')).toMatchSnapshot();
185-
expect(containerThird.querySelector('.rc-virtual-list')).toMatchSnapshot();
183+
expect(containerFirst.querySelector('.rc-select-dropdown-list')).toMatchSnapshot();
184+
expect(containerSecond.querySelector('.rc-select-dropdown-list')).toMatchSnapshot();
185+
expect(containerThird.querySelector('.rc-select-dropdown-list')).toMatchSnapshot();
186186
});
187187
});
188188

@@ -2619,7 +2619,7 @@ describe('Select.Basic', () => {
26192619
const options = new Array(10).fill(null).map((_, value) => ({ value }));
26202620

26212621
const { container } = testingRender(<Select open direction="rtl" options={options} />);
2622-
expect(container.querySelector('.rc-virtual-list-rtl')).toBeTruthy();
2622+
expect(container.querySelector('.rc-select-dropdown-list-rtl')).toBeTruthy();
26232623
});
26242624

26252625
it('Should optionRender work', () => {
@@ -2720,7 +2720,7 @@ describe('Select.Basic', () => {
27202720
/>,
27212721
);
27222722
const element = container.querySelectorAll<HTMLDivElement>(
2723-
'div.rc-virtual-list-holder-inner .rc-select-item',
2723+
'div.rc-select-dropdown-list-holder-inner .rc-select-item',
27242724
);
27252725
expect(element[0]).not.toHaveClass('rc-select-item-option-disabled');
27262726
expect(element[1]).toHaveClass('rc-select-item-option-disabled');
@@ -2811,7 +2811,7 @@ describe('Select.Basic', () => {
28112811
const prefix = container.querySelector('.rc-select-prefix');
28122812
const suffix = container.querySelector('.rc-select-suffix');
28132813
const item = container.querySelector('.rc-select-item-option');
2814-
const list = container.querySelector('.rc-virtual-list');
2814+
const list = container.querySelector('.rc-select-dropdown-list');
28152815
const input = container.querySelector('input');
28162816
expect(prefix).toHaveClass(customClassNames.prefix);
28172817
expect(prefix).toHaveStyle(customStyle.prefix);

‎tests/__snapshots__/OptionList.test.tsx.snap‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,15 @@ exports[`OptionList renders correctly virtual 1`] = `
2727
/>
2828
</div>
2929
<div
30-
class="rc-virtual-list"
30+
class="rc-select-dropdown-list"
3131
style="position: relative;"
3232
>
3333
<div
34-
class="rc-virtual-list-holder"
34+
class="rc-select-dropdown-list-holder"
3535
>
3636
<div>
3737
<div
38-
class="rc-virtual-list-holder-inner"
38+
class="rc-select-dropdown-list-holder-inner"
3939
style="display: flex; flex-direction: column;"
4040
>
4141
<div
@@ -102,15 +102,15 @@ exports[`OptionList renders correctly virtual 1`] = `
102102
exports[`OptionList renders correctly without virtual 1`] = `
103103
<div>
104104
<div
105-
class="rc-virtual-list"
105+
class="rc-select-dropdown-list"
106106
style="position: relative;"
107107
>
108108
<div
109-
class="rc-virtual-list-holder"
109+
class="rc-select-dropdown-list-holder"
110110
>
111111
<div>
112112
<div
113-
class="rc-virtual-list-holder-inner"
113+
class="rc-select-dropdown-list-holder-inner"
114114
id="undefined_list"
115115
role="listbox"
116116
style="display: flex; flex-direction: column;"

‎tests/__snapshots__/Select.test.tsx.snap‎

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -29,16 +29,16 @@ exports[`Select.Basic does not filter when filterOption value is false 1`] = `
2929
</div>
3030
</div>
3131
<div
32-
class="rc-virtual-list"
32+
class="rc-select-dropdown-list"
3333
style="position: relative;"
3434
>
3535
<div
36-
class="rc-virtual-list-holder"
36+
class="rc-select-dropdown-list-holder"
3737
style="max-height: 200px; overflow-y: auto;"
3838
>
3939
<div>
4040
<div
41-
class="rc-virtual-list-holder-inner"
41+
class="rc-select-dropdown-list-holder-inner"
4242
style="display: flex; flex-direction: column;"
4343
>
4444
<div
@@ -265,16 +265,16 @@ exports[`Select.Basic render renders role prop correctly 1`] = `
265265

266266
exports[`Select.Basic render should support fieldName 1`] = `
267267
<div
268-
class="rc-virtual-list"
268+
class="rc-select-dropdown-list"
269269
style="position: relative;"
270270
>
271271
<div
272-
class="rc-virtual-list-holder"
272+
class="rc-select-dropdown-list-holder"
273273
style="max-height: 200px; overflow-y: auto;"
274274
>
275275
<div>
276276
<div
277-
class="rc-virtual-list-holder-inner"
277+
class="rc-select-dropdown-list-holder-inner"
278278
style="display: flex; flex-direction: column;"
279279
>
280280
<div
@@ -312,16 +312,16 @@ exports[`Select.Basic render should support fieldName 1`] = `
312312

313313
exports[`Select.Basic render should support fieldName 2`] = `
314314
<div
315-
class="rc-virtual-list"
315+
class="rc-select-dropdown-list"
316316
style="position: relative;"
317317
>
318318
<div
319-
class="rc-virtual-list-holder"
319+
class="rc-select-dropdown-list-holder"
320320
style="max-height: 200px; overflow-y: auto;"
321321
>
322322
<div>
323323
<div
324-
class="rc-virtual-list-holder-inner"
324+
class="rc-select-dropdown-list-holder-inner"
325325
style="display: flex; flex-direction: column;"
326326
>
327327
<div
@@ -359,16 +359,16 @@ exports[`Select.Basic render should support fieldName 2`] = `
359359

360360
exports[`Select.Basic render should support fieldName 3`] = `
361361
<div
362-
class="rc-virtual-list"
362+
class="rc-select-dropdown-list"
363363
style="position: relative;"
364364
>
365365
<div
366-
class="rc-virtual-list-holder"
366+
class="rc-select-dropdown-list-holder"
367367
style="max-height: 200px; overflow-y: auto;"
368368
>
369369
<div>
370370
<div
371-
class="rc-virtual-list-holder-inner"
371+
class="rc-select-dropdown-list-holder-inner"
372372
style="display: flex; flex-direction: column;"
373373
>
374374
<div
@@ -433,16 +433,16 @@ exports[`Select.Basic should contain falsy children 1`] = `
433433
</div>
434434
</div>
435435
<div
436-
class="rc-virtual-list"
436+
class="rc-select-dropdown-list"
437437
style="position: relative;"
438438
>
439439
<div
440-
class="rc-virtual-list-holder"
440+
class="rc-select-dropdown-list-holder"
441441
style="max-height: 200px; overflow-y: auto;"
442442
>
443443
<div>
444444
<div
445-
class="rc-virtual-list-holder-inner"
445+
class="rc-select-dropdown-list-holder-inner"
446446
style="display: flex; flex-direction: column;"
447447
>
448448
<div
@@ -532,16 +532,16 @@ exports[`Select.Basic should render custom dropdown correctly 1`] = `
532532
</div>
533533
</div>
534534
<div
535-
class="rc-virtual-list"
535+
class="rc-select-dropdown-list"
536536
style="position: relative;"
537537
>
538538
<div
539-
class="rc-virtual-list-holder"
539+
class="rc-select-dropdown-list-holder"
540540
style="max-height: 200px; overflow-y: auto;"
541541
>
542542
<div>
543543
<div
544-
class="rc-virtual-list-holder-inner"
544+
class="rc-select-dropdown-list-holder-inner"
545545
style="display: flex; flex-direction: column;"
546546
>
547547
<div

‎tests/__snapshots__/Tags.test.tsx.snap‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -106,16 +106,16 @@ exports[`Select.Tags OptGroup renders correctly 1`] = `
106106
/>
107107
</div>
108108
<div
109-
class="rc-virtual-list"
109+
class="rc-select-dropdown-list"
110110
style="position: relative;"
111111
>
112112
<div
113-
class="rc-virtual-list-holder"
113+
class="rc-select-dropdown-list-holder"
114114
style="max-height: 200px; overflow-y: auto;"
115115
>
116116
<div>
117117
<div
118-
class="rc-virtual-list-holder-inner"
118+
class="rc-select-dropdown-list-holder-inner"
119119
style="display: flex; flex-direction: column;"
120120
>
121121
<div

0 commit comments

Comments
 (0)