Skip to content

Commit cda5aeb

Browse files
刘欢claude
andcommitted
refactor: make isHandleDisabled required in context
- Change isHandleDisabled from optional to required in SliderContextProps - Remove unnecessary null checks in Tracks and Handle components Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 9584ac3 commit cda5aeb

3 files changed

Lines changed: 2 additions & 4 deletions

File tree

src/Handles/Handle.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,7 @@ const Handle = React.forwardRef<HTMLDivElement, HandleProps>((props, ref) => {
6868
isHandleDisabled,
6969
} = React.useContext(SliderContext);
7070

71-
const handleDisabled =
72-
globalDisabled || (isHandleDisabled ? isHandleDisabled(valueIndex) : false);
71+
const handleDisabled = globalDisabled || isHandleDisabled(valueIndex);
7372

7473
const handlePrefixCls = `${prefixCls}-handle`;
7574

src/Tracks/index.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ const Tracks: React.FC<TrackProps> = (props) => {
1818
const { included, range, min, styles, classNames, isHandleDisabled } = React.useContext(SliderContext);
1919

2020
const hasDisabledHandle = React.useMemo(() => {
21-
if (!isHandleDisabled) return false;
2221
for (let i = 0; i < values.length; i++) {
2322
if (isHandleDisabled(i)) return true;
2423
}

src/context.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export interface SliderContextProps {
1919
ariaValueTextFormatterForHandle?: AriaValueFormat | AriaValueFormat[];
2020
classNames: SliderClassNames;
2121
styles: SliderStyles;
22-
isHandleDisabled?: (index: number) => boolean;
22+
isHandleDisabled: (index: number) => boolean;
2323
}
2424

2525
const SliderContext = React.createContext<SliderContextProps>({

0 commit comments

Comments
 (0)