chore: run eslint over test files and fix surfaced errors (#374)

* chore: run eslint over test files and fix surfaced errors

The `lint` script only scanned `src/`, so the jest config block for
`tests/**` in eslint.config.mjs never actually ran. Extend the script to
cover `tests/` and fix the 3 errors it surfaces:

- domHook.js: setter used `return` for control flow, but a setter's return
  value is silently discarded (no-setter-return) -> use if/else
- scroll.test.js: oversized deltaY literal lost precision
  (no-loss-of-precision) -> 1e20, same magnitude
- drop dead `eslint-disable no-param-reassign` directives in domHook.js and
  useScrollTo.tsx (the rule isn't enabled)

* update

Author: aojunhao123

.github/workflows/react-doctor.yml

@@ -19,6 +19,4 @@ jobs:
       - uses: actions/checkout@v7
         with:
           persist-credentials: false
-      - uses: millionco/react-doctor@0b4f4f4bd248a154e64eb508a48347f71154b3f3
-        with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
+      - uses: millionco/react-doctor@964622bf15fa5f8eef7e05196407aa08dc779087 # v2.2.7

package.json

@@ -35,7 +35,7 @@
     "docs:deploy": "gh-pages -d docs-dist",
     "deploy": "npm run gh-pages",
     "gh-pages": "npm run compile && cross-env GH_PAGES=1 npm run docs:build && npm run docs:deploy",
-    "lint": "eslint src/ --ext .tsx,.ts",
+    "lint": "eslint src/ tests/ --ext .tsx,.ts,.jsx,.js",
     "prepublishOnly": "npm run compile && rc-np",
     "prettier": "prettier --write --ignore-unknown .",
     "start": "dumi dev",

src/hooks/useScrollTo.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable no-param-reassign */
 import * as React from 'react';
 import { raf, useLayoutEffect, warning } from '@rc-component/util';
 import type { GetKey, GetSize } from '../interface';

tests/scroll.test.js

@@ -559,7 +559,7 @@ describe('List.Scroll', () => {
     const holder = container.querySelector('ul');
 
     const event = createEvent.wheel(holder, {
-      deltaY: 99999999999999999999,
+      deltaY: 1e20,
     });
     fireEvent(holder, event);
 

tests/utils/domHook.js

@@ -1,11 +1,10 @@
-/* eslint-disable no-param-reassign */
 const NO_EXIST = { __NOT_EXIST: true };
 
 export function spyElementPrototypes(Element, properties) {
   const propNames = Object.keys(properties);
   const originDescriptors = {};
 
-  propNames.forEach(propName => {
+  propNames.forEach((propName) => {
     const originDescriptor = Object.getOwnPropertyDescriptor(Element.prototype, propName);
     originDescriptors[propName] = originDescriptor || NO_EXIST;
 
@@ -22,9 +21,10 @@ export function spyElementPrototypes(Element, properties) {
         ...spyProp,
         set(value) {
           if (spyProp.set) {
-            return spyProp.set.call(this, originDescriptor, value);
+            spyProp.set.call(this, originDescriptor, value);
+          } else {
+            originDescriptor.set(value);
           }
-          return originDescriptor.set(value);
         },
         get() {
           if (spyProp.get) {
@@ -39,7 +39,7 @@ export function spyElementPrototypes(Element, properties) {
 
   return {
     mockRestore() {
-      propNames.forEach(propName => {
+      propNames.forEach((propName) => {
         const originDescriptor = originDescriptors[propName];
         if (originDescriptor === NO_EXIST) {
           delete Element.prototype[propName];
@@ -58,4 +58,3 @@ export function spyElementPrototype(Element, propName, property) {
     [propName]: property,
   });
 }
-/* eslint-enable no-param-reassign */