refactor: simplify migrated TS (types, casts, config)

Quality cleanups from a /simplify pass, no behavior or API change: move the public DraggableEvent union into lib/utils/types.ts alongside the other public types (it was the lone public type defined in the entry file) and re-export it from cjs.ts; replace 'as Pick<DraggableState, keyof DraggableState>' with the equivalent 'as DraggableState'; drop DraggableCore's redundant propTypes index-signature annotation to match Draggable; remove inert declaration/emitDeclarationOnly/outDir keys from the root tsconfig (noEmit wins; tsup owns dts emit); fix a stale fixture comment that described build-artifact validation after it was repointed at source.

Author: STRML

lib/Draggable.tsx

@@ -348,7 +348,7 @@ class Draggable extends React.Component<Partial<DraggableProps>, DraggableState>
       newState.y = y;
     }
 
-    this.setState(newState as Pick<DraggableState, keyof DraggableState>);
+    this.setState(newState as DraggableState);
   };
 
   render(): ReactElement {

lib/DraggableCore.tsx

@@ -73,7 +73,7 @@ export default class DraggableCore extends React.Component<Partial<DraggableCore
 
   static displayName: string | undefined = 'DraggableCore';
 
-  static propTypes: {[key: string]: unknown} = {
+  static propTypes = {
     /**
      * `allowAnyClick` allows dragging using any mouse button.
      * By default, we only accept the left button.

lib/cjs.ts

@@ -61,18 +61,6 @@ export type {
   PositionOffsetControlPosition,
 } from './DraggableCore';
 // `DraggableBounds` was the public name for the internal `Bounds` type.
-export type {Bounds as DraggableBounds} from './utils/types';
-
-// `DraggableEvent` is the PUBLIC event type. Historically (typings/index.d.ts) it
-// was the broad UNION of the React synthetic and native DOM mouse/touch events a
-// consumer might receive — NOT the internal `MouseTouchEvent` (which is the
-// `MouseEvent & TouchEvent` intersection the handlers use for convenient field
-// access). Aliasing the public type to the intersection would be an API break:
-// none of the old union members are assignable to the intersection. Keep the
-// union to preserve compatibility.
-import type * as React from 'react';
-export type DraggableEvent =
-  | React.MouseEvent<HTMLElement | SVGElement>
-  | React.TouchEvent<HTMLElement | SVGElement>
-  | MouseEvent
-  | TouchEvent;
+// `DraggableEvent` is the public event union (defined in ./utils/types alongside
+// the other public types — see the note there on why it must stay a union).
+export type {Bounds as DraggableBounds, DraggableEvent} from './utils/types';

lib/utils/types.ts

@@ -1,3 +1,5 @@
+import type * as React from 'react';
+
 export type DraggableEventHandler = (e: MouseEvent, data: DraggableData) => void | false;
 
 export type DraggableData = {
@@ -17,3 +19,16 @@ export type EventHandler<T> = (e: T) => void | false;
 // MouseEvent and TouchEvent are provided by the TS DOM lib, including
 // changedTouches/targetTouches, so the Flow class shims are no longer needed.
 export type MouseTouchEvent = MouseEvent & TouchEvent;
+
+// `DraggableEvent` is the PUBLIC event type a consumer's handlers may receive.
+// Historically (the old typings/index.d.ts) it was the broad UNION of React
+// synthetic and native DOM mouse/touch events — NOT the internal
+// `MouseTouchEvent` intersection above (which exists only for convenient field
+// access inside the handlers). Aliasing the public type to the intersection
+// would be an API break: none of the union members are assignable to it. Keep
+// the union to preserve compatibility.
+export type DraggableEvent =
+  | React.MouseEvent<HTMLElement | SVGElement>
+  | React.TouchEvent<HTMLElement | SVGElement>
+  | MouseEvent
+  | TouchEvent;

test/typeCompat/fixture.tsx

@@ -1,9 +1,10 @@
 // Type-level compatibility fixture.
 //
 // This file is NOT run; it is compiled by `test/typeCompat.test.ts` via `tsc`
-// against the AUTO-GENERATED declaration (build/cjs/cjs.d.ts, aliased to
-// "react-draggable"). It asserts that the generated public type surface is
-// API-compatible with the OLD hand-written typings/index.d.ts.
+// against the source entry (lib/cjs.ts, aliased to "react-draggable") — the same
+// public surface the shipped declaration is generated from, checked without
+// requiring a prior build. It asserts that surface is API-compatible with the
+// OLD hand-written typings/index.d.ts.
 //
 // Every exported name and every prop from the old surface is exercised here. If
 // any export is removed/renamed, or any prop is removed/renamed/retyped

tsconfig.json

@@ -5,9 +5,6 @@
     "moduleResolution": "bundler",
     "lib": ["ES2019", "DOM", "DOM.Iterable"],
     "jsx": "react",
-    "declaration": true,
-    "emitDeclarationOnly": false,
-    "outDir": "build/cjs",
     "strict": true,
     "esModuleInterop": true,
     "allowSyntheticDefaultImports": true,