fix(ci): make typecheck/lint/test build-order-independent

CI was red because the migration left three build-order assumptions that only surfaced in a fresh checkout: the typecheck job still ran the removed `yarn flow`; `make lint` and the typeCompat test resolved `react-draggable` to the generated build/cjs/cjs.d.ts, which doesn't exist before `yarn build`. The workflow's own verify ran against a pre-populated build/, hiding it.

Repoint typings/tsconfig.json and test/typeCompat/tsconfig.json at the source entry (lib/cjs.ts) instead of the built declaration — same public surface, no build dependency. Drop the build-exists guard in typeCompat.test.ts. Replace the dead `yarn flow` CI step with `yarn tsc --noEmit`. Verified lint/typecheck/test/coverage/build all green with build/ absent.

Author: STRML

.github/workflows/ci.yml

@@ -98,8 +98,8 @@ jobs:
       - name: Install dependencies
         run: yarn install --frozen-lockfile
 
-      - name: Flow check
-        run: yarn flow
+      - name: TypeScript check (source)
+        run: yarn tsc --noEmit
 
-      - name: TypeScript check
+      - name: TypeScript check (public typings)
         run: yarn tsc -p typings

test/typeCompat.test.ts

@@ -1,36 +1,36 @@
-import {describe, it, expect, beforeAll} from 'vitest';
+import {describe, it, expect} from 'vitest';
 import {execFileSync} from 'node:child_process';
-import {existsSync} from 'node:fs';
 import {resolve, dirname} from 'node:path';
 import {fileURLToPath} from 'node:url';
 import {createRequire} from 'node:module';
 
 // ─────────────────────────────────────────────────────────────────────────────
 // Public type-surface compatibility guard.
 //
-// After the Flow -> TypeScript migration the public `.d.ts` is AUTO-GENERATED
-// from source (build/cjs/cjs.d.ts) instead of hand-written (the old
-// typings/index.d.ts, now deleted). This test asserts the generated surface is
-// still API-compatible with that old surface by compiling two type-assertion
-// files against the generated declaration with `tsc`:
+// After the Flow -> TypeScript migration the public `.d.ts` is generated from the
+// source entry (lib/cjs.ts) instead of hand-written (the old typings/index.d.ts,
+// now deleted). The published declaration is a faithful tsc/tsup projection of
+// that source surface, so this test asserts compatibility against the source
+// entry directly — which keeps the check build-order-independent (no prior
+// `yarn build` required) while exercising the exact public surface the shipped
+// `.d.ts` is derived from. The build itself (tsup --dts) is what guarantees the
+// declaration emits cleanly.
 //
+// Both projects below map `react-draggable` -> ../lib/cjs.ts and compile with
+// `tsc`:
 //   1. test/typeCompat/fixture.tsx — exhaustively exercises every exported name
 //      and every prop from the old typings/index.d.ts. Removing/renaming/retyping
-//      any export or prop makes this stop compiling.
+//      any export or prop (e.g. narrowing children from ReactNode) stops it
+//      compiling.
 //   2. typings/test.tsx — the project's existing consumer-style smoke test,
-//      compiled UNCHANGED against the generated types (incl. zero-prop usage,
-//      which only works if the public props remain optional like the old
-//      `Partial<DraggableProps>` surface).
-//
-// If the CJS declaration hasn't been built yet, the test fails with an actionable
-// message rather than silently passing.
+//      compiled UNCHANGED (incl. zero-prop usage, which only works if the public
+//      props remain optional like the old `Partial<DraggableProps>` surface).
 // ─────────────────────────────────────────────────────────────────────────────
 
 const __dirname = dirname(fileURLToPath(import.meta.url));
 const repoRoot = resolve(__dirname, '..');
 const require = createRequire(import.meta.url);
 const tscBin = require.resolve('typescript/bin/tsc');
-const generatedDts = resolve(repoRoot, 'build/cjs/cjs.d.ts');
 
 function runTsc(projectDir: string): {ok: boolean; output: string} {
   try {
@@ -47,22 +47,13 @@ function runTsc(projectDir: string): {ok: boolean; output: string} {
 }
 
 describe('public type-surface compatibility', () => {
-  beforeAll(() => {
-    if (!existsSync(generatedDts)) {
-      throw new Error(
-        `Generated declaration not found at ${generatedDts}. Run \`yarn build\` ` +
-          `before running the type-compat test (it asserts against the built .d.ts).`
-      );
-    }
-  });
-
-  it('generated .d.ts is API-compatible with the old hand-written surface', () => {
+  it('public surface is API-compatible with the old hand-written surface', () => {
     const {ok, output} = runTsc(resolve(__dirname, 'typeCompat'));
     expect(output, output).toBe('');
     expect(ok).toBe(true);
   });
 
-  it('the existing typings/test.tsx still compiles unchanged against generated types', () => {
+  it('the existing typings/test.tsx still compiles unchanged against the public surface', () => {
     const {ok, output} = runTsc(resolve(repoRoot, 'typings'));
     expect(output, output).toBe('');
     expect(ok).toBe(true);

test/typeCompat/tsconfig.json

@@ -10,7 +10,7 @@
     "types": ["react", "react-dom", "node"],
     "baseUrl": ".",
     "paths": {
-      "react-draggable": ["../../build/cjs/cjs.d.ts"]
+      "react-draggable": ["../../lib/cjs.ts"]
     }
   },
   "files": [

typings/tsconfig.json

@@ -7,7 +7,7 @@
     "esModuleInterop": true,
     "baseUrl": ".",
     "paths": {
-      "react-draggable": ["../build/cjs/cjs.d.ts"]
+      "react-draggable": ["../lib/cjs.ts"]
     }
   },
   "files": [