Merge pull request #86 from panter/improve-snapshot-stuff

allow to specify options for image capture

Author: macrozone

ARKit.js

@@ -156,6 +156,14 @@ Object.keys(ARKitManager).forEach(key => {
   ARKit[key] = ARKitManager[key];
 });
 
+const addDefaultsToSnapShotFunc = funcName => ({
+  target = 'cameraRoll',
+  format = 'png',
+}) => ARKitManager[funcName]({ target, format });
+
+ARKit.snapshot = addDefaultsToSnapShotFunc('snapshot');
+ARKit.snapshotCamera = addDefaultsToSnapShotFunc('snapshotCamera');
+
 ARKit.exportModel = presetId => {
   const id = presetId || generateId();
   const property = { id };

ios/RCTARKit.h

@@ -56,8 +56,8 @@ typedef void (^RCTARKitReject)(NSString *code, NSString *message, NSError *error
 - (void)hitTestSceneObjects:(CGPoint)tapPoint resolve:(RCTARKitResolve) resolve reject:(RCTARKitReject)reject;
 - (SCNVector3)projectPoint:(SCNVector3)point;
 - (float)getCameraDistanceToPoint:(SCNVector3)point;
-- (void)snapshot:(RCTARKitResolve)resolve reject:(RCTARKitReject)reject;
-- (void)snapshotCamera:(RCTARKitResolve)resolve reject:(RCTARKitReject)reject;
+- (UIImage *)getSnaphshot;
+- (UIImage *)getSnaphshotCamera;
 - (void)focusScene;
 - (void)clearScene;
 - (NSDictionary *)readCameraPosition;

ios/RCTARKit.m

@@ -231,40 +231,32 @@ - (void)hitTestSceneObjects:(const CGPoint)tapPoint resolve:(RCTARKitResolve)res
 }
 
 
-- (void)snapshot:(RCTARKitResolve)resolve reject:(RCTARKitReject)reject {
+- (UIImage *)getSnaphshot {
     UIImage *image = [self.arView snapshot];
-    // FIXME: I belive this is not the right way. I don't know how to pass 'resolve' to the completionSelector
-    // If you know how to do it, please PR. Thanks!
-    _resolve = resolve;
-    UIImageWriteToSavedPhotosAlbum(image, self, @selector(thisImage:savedInAlbumWithError:ctx:), NULL);
+    return image;
 }
 
 
-- (void)snapshotCamera:(RCTARKitResolve)resolve reject:(RCTARKitReject)reject {
 
-    // thx https://stackoverflow.com/a/8094038/1463534
+
+
+- (UIImage *)getSnaphsotCamera {
     CVPixelBufferRef pixelBuffer = self.arView.session.currentFrame.capturedImage;
     CIImage *ciImage = [CIImage imageWithCVPixelBuffer:pixelBuffer];
-
+    
     CIContext *temporaryContext = [CIContext contextWithOptions:nil];
     CGImageRef videoImage = [temporaryContext
                              createCGImage:ciImage
                              fromRect:CGRectMake(0, 0,
                                                  CVPixelBufferGetWidth(pixelBuffer),
                                                  CVPixelBufferGetHeight(pixelBuffer))];
-
+    
     UIImage *image = [UIImage imageWithCGImage:videoImage scale: 1.0 orientation:UIImageOrientationRight];
     CGImageRelease(videoImage);
-    _resolve = resolve;
-    UIImageWriteToSavedPhotosAlbum(image, self, @selector(thisImage:savedInAlbumWithError:ctx:), NULL);
+    return image;
 }
 
-- (void)thisImage:(UIImage *)image savedInAlbumWithError:(NSError *)error ctx:(void *)ctx {
-    if (error) {
-    } else {
-        _resolve(@{ @"success": @(YES) });
-    }
-}
+
 
 
 

ios/RCTARKitManager.m

@@ -9,6 +9,8 @@
 #import "RCTARKitManager.h"
 #import "RCTARKit.h"
 #import "RCTARKitNodes.h"
+#import <UIKit/UIKit.h>
+#import <Photos/Photos.h>
 
 @implementation RCTARKitManager
 
@@ -95,12 +97,104 @@ - (NSDictionary *)constantsToExport
 
 
 
-RCT_EXPORT_METHOD(snapshot:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject) {
-    [[ARKit sharedInstance] snapshot:resolve reject:reject];
+- (NSString *)getAssetUrl:(NSString *)localID {
+    // thx https://stackoverflow.com/a/34788748/1463534
+    // heck, objective c is such a mess
+    NSString *  assetID = [localID stringByReplacingOccurrencesOfString:@"/.*" withString:@"" options:NSRegularExpressionSearch range:NSMakeRange(0, [localID length])];
+    NSString * ext = @"JPG";
+    NSString * assetURLStr = [NSString stringWithFormat:@"assets-library://asset/asset.%@?id=%@&ext=%@", ext, assetID, ext];
+    return assetURLStr;
 }
 
-RCT_EXPORT_METHOD(snapshotCamera:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject) {
-    [[ARKit sharedInstance] snapshotCamera:resolve reject:reject];
+- (void)storeImageInPhotoAlbum:(UIImage *)image reject:(RCTPromiseRejectBlock)reject resolve:(RCTPromiseResolveBlock)resolve {
+    __block PHObjectPlaceholder *placeholder;
+    
+    [[PHPhotoLibrary sharedPhotoLibrary] performChanges:^{
+        PHAssetChangeRequest* createAssetRequest = [PHAssetChangeRequest creationRequestForAssetFromImage:image];
+        placeholder = [createAssetRequest placeholderForCreatedAsset];
+        
+    } completionHandler:^(BOOL success, NSError *error) {
+        if (success)
+        {
+            
+            NSString * localID = placeholder.localIdentifier;
+            
+            NSString * assetURLStr = [self getAssetUrl:localID];
+            
+            resolve(@{@"url": assetURLStr, @"width":@(image.size.width), @"height": @(image.size.height)});
+        }
+        else
+        {
+            reject(@"snapshot_error", @"Could not store snapshot", error);
+        }
+    }];
+}
+
+
+- (void)storeImageInDirectory:(UIImage *)image directory:(NSString *)directory format:(NSString *)format reject:(RCTPromiseRejectBlock)reject resolve:(RCTPromiseResolveBlock)resolve {
+    NSData *data;
+    if([format isEqualToString:@"jpg"]) {
+        data = UIImageJPEGRepresentation(image, 0.9);
+    } else if([format isEqualToString:@"png"]) {
+        data = UIImagePNGRepresentation(image);
+    } else {
+        reject(@"snapshot_error", [NSString stringWithFormat:@"unkown file format '%@'", format], nil);
+        return;
+    }
+    NSString *prefixString = @"capture";
+    
+    NSString *guid = [[NSProcessInfo processInfo] globallyUniqueString] ;
+    NSString *uniqueFileName = [NSString stringWithFormat:@"%@_%@.%@", prefixString, guid, format];
+    
+    NSString *filePath = [directory stringByAppendingPathComponent:uniqueFileName]; //Add the file name
+    bool success = [data writeToFile:filePath atomically:YES]; //Write the file
+    if(success) {
+        resolve(@{@"url": filePath, @"width":@(image.size.width), @"height": @(image.size.height)});
+    } else {
+        // TODO use NSError from writeToFile
+        reject(@"snapshot_error",  [NSString stringWithFormat:@"could not save to '%@'", filePath], nil);
+    }
+    
+}
+
+- (void)storeImage:(UIImage *)image options:(NSDictionary *)options reject:(RCTPromiseRejectBlock)reject resolve:(RCTPromiseResolveBlock)resolve {
+    NSString * target = @"cameraRoll";
+    NSString * format = @"png";
+    
+    if(options[@"target"]) {
+        target = options[@"target"];
+    }
+    if(options[@"format"]) {
+        format = options[@"format"];
+    }
+    if([target isEqualToString:@"cameraRoll"]) {
+        // camera roll / photo album
+        [self storeImageInPhotoAlbum:image reject:reject resolve:resolve];
+    } else {
+        NSString * dir;
+        if([target isEqualToString:@"cache"]) {
+            dir =  [NSSearchPathForDirectoriesInDomains(NSCachesDirectory, NSUserDomainMask, YES) firstObject];
+        } else if([target isEqualToString:@"documents"]) {
+            dir =  [NSSearchPathForDirectoriesInDomains(NSDocumentDirectory, NSUserDomainMask, YES) firstObject];
+            
+        } else {
+            dir = target;
+        }
+        [self storeImageInDirectory:image directory:dir format:format reject:reject resolve:resolve];
+    }
+}
+
+RCT_EXPORT_METHOD(snapshot:(NSDictionary *)options resolve:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject) {
+    UIImage *image = [[ARKit sharedInstance] getSnaphshot];
+    [self storeImage:image options:options reject:reject resolve:resolve];
+}
+
+
+
+
+RCT_EXPORT_METHOD(snapshotCamera:(NSDictionary *)options resolve:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject) {
+    UIImage *image = [[ARKit sharedInstance] getSnaphshotCamera];
+    [self storeImage:image options:options reject:reject resolve:resolve];
 }
 
 RCT_EXPORT_METHOD(getCamera:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject) {
@@ -138,3 +232,4 @@ - (NSDictionary *)constantsToExport
 }
 
 @end
+