small code tweaks and cleanups spotted when working on experiment (#2167)

Author: Simek

components/Library/index.tsx

@@ -33,8 +33,7 @@ export default function Library({
   const { github } = library;
   const { isSmallScreen, isBelowMaxWidth } = useLayout();
 
-  const libName = library.npmPkg ?? github.name;
-  const bookmarkId = library.npmPkg ?? library.github.fullName;
+  const libName = library.npmPkg ?? github.fullName;
 
   const hasSecondaryMetadata =
     github.license ||
@@ -54,7 +53,7 @@ export default function Library({
         library.unmaintained && tw`opacity-85`,
       ]}>
       <BookmarkButton
-        bookmarkId={bookmarkId}
+        bookmarkId={libName}
         style={tw`absolute right-2.5 top-2.5 z-10 rounded border border-palette-gray2 p-1.5 dark:border-palette-gray6`}
       />
       <View

pages/api/libraries/index.ts

@@ -91,7 +91,6 @@ export default function handler(req: NextApiRequest, res: NextApiResponse) {
     configPlugin: parsedQuery.configPlugin,
     isMaintained: parsedQuery.isMaintained,
     isPopular: parsedQuery.isPopular,
-    isRecommended: parsedQuery.isRecommended,
     wasRecentlyUpdated: parsedQuery.wasRecentlyUpdated,
     minPopularity: parsedQuery.minPopularity,
     minMonthlyDownloads: parsedQuery.minMonthlyDownloads,

scripts/build-and-score-data.ts

@@ -98,12 +98,10 @@ async function buildAndScoreData() {
   const fetchList: string[] = [];
 
   // Filter out template entries, prepare npm-stat API chunks
-  data = data.map(project => {
+  data.forEach(project => {
     if (!project.template) {
       fetchList.push(project.npmPkg);
-      return project;
     }
-    return project;
   });
 
   // Assemble and fetch packages data in bulk queries
@@ -439,7 +437,7 @@ async function fetchNpmStatDataSequentially(bulkList: string[][]) {
 async function fetchNpmRegistryDataSequentially(list: LibraryType[]) {
   const total = list.length;
 
-  for (let i = 0; i < list.length; i++) {
+  for (let i = 0; i < total; i++) {
     const entry = list[i];
 
     if (!entry || entry.template) {

types/index.ts

@@ -43,7 +43,6 @@ export type Query = {
   configPlugin?: string;
   isMaintained?: string;
   isPopular?: string;
-  isRecommended?: string;
   wasRecentlyUpdated?: string;
   minPopularity?: string;
   minMonthlyDownloads?: string;

util/search.ts

@@ -89,7 +89,6 @@ export function handleFilterLibraries({
   configPlugin,
   isMaintained,
   isPopular,
-  isRecommended,
   wasRecentlyUpdated,
   minPopularity,
   minMonthlyDownloads,
@@ -252,10 +251,6 @@ export function handleFilterLibraries({
       return false;
     }
 
-    if (isRecommended && !library.matchingScoreModifiers.includes('Recommended')) {
-      return false;
-    }
-
     if (wasRecentlyUpdated && !library.matchingScoreModifiers.includes('Recently updated')) {
       return false;
     }