Added my own fork of react-native-copilot so that Expo CLI does not keep warning me about it#1657
Added my own fork of react-native-copilot so that Expo CLI does not keep warning me about it#1657Proman4713 wants to merge 3 commits intoreact-native-community:mainfrom
react-native-copilot so that Expo CLI does not keep warning me about it#1657Conversation
|
Hey @Proman4713, can you share the screenshot of warning you are wanting to resolve? |
|
|
|
Thanks for sharing! What's the exact command you are executing? Since we do the validation in CLI, in two places, and one more check is also made by |
|
We offer a way to customize the checks and ignore given packages or scopes (usually local one, or private forks), but it might not apply in all cases when the check is performed, hence the question before recommending that approach: |
|
expo doctor |
|
i dont want to exclude these libraries from the directory check, why can't I just properly tell the directory whether or not they work for the new architecture? |
|
Usually it's easier to ignore private forks and packages than listing all of the forks of existing libraries. If we would do that, then the directory would be in tens of thousands entries, and the usability of it would be questionable due to shear amount of data, so we need to have some limiting factor. You initial PR comment suggested directly that your package is not created to be used by others, it's just a fork for your own purpose, and repo stats reflect that. That's why I have suggested excluding the check. If your fork grow, and got some other users usage and traction, there is no reason why it cannot be added later in time. |
|
Alright, you have got a point.. I will manually exclude the fork on my end... But I'll still test the other packages and make PRs for them if they work |
|
Closing the PR according to the discussion above. Few notes on the remaining packages from the screenshot:
Saying that, feel free to propose new additions, or missing packages in a new PRs, if you find any other warning for your codebase! |

📝 Why & how
Add a new library
✅ Checklist
react-native-libraries.jsonreact-native-libraries.json