Add patch-package and postinstall-postinstall#1673
Closed
metehandemir wants to merge 2 commits intoreact-native-community:mainfrom
Closed
Add patch-package and postinstall-postinstall#1673metehandemir wants to merge 2 commits intoreact-native-community:mainfrom
metehandemir wants to merge 2 commits intoreact-native-community:mainfrom
Conversation
Simek
reviewed
May 31, 2025
Member
Simek
left a comment
Simek
left a comment
There was a problem hiding this comment.
Hey @metehandemir, thanks for the contribution, but both of those packages should be installed as dev dependencies, and they do not have strong connection to the React Native ecosystem.
I wonder the root is an invalid dependency categorization, or do we warn for unwanted category (devDependencies) somewhere in our tooling?
Contributor
Author
|
My bad, sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Why & how
Added patch-package and postinstall-postinstall.
✅ Checklist
react-native-libraries.jsonreact-native-libraries.json