Add react-error-boundary to directory#1758
Add react-error-boundary to directory#1758Simek merged 2 commits intoreact-native-community:mainfrom
Conversation
react-native-libraries.json
Outdated
| { | ||
| "githubUrl": "https://github.com/expo/expo/tree/main/packages/eslint-config-expo", | ||
| "npmPkg": "eslint-config-expo", | ||
| "ios": true, | ||
| "android": true, | ||
| "web": true, | ||
| "expoGo": true, | ||
| "newArchitecture": true |
There was a problem hiding this comment.
Hey @Minori-ty, in general the ESLint configs should be installed as developer dependency, so they should be omitted during different checks (made by Expo CLI or expo-doctor).
We also tend to not accept ESLint related packages, since there is so many of configs and plugins, and they will clutter the directory.
There was a problem hiding this comment.
Thank you for your reply. I will try to ignore eslint-config-expo in expo-doctor.
Hey @Minori-ty, in general the ESLint configs should be installed as developer dependency, so they should be omitted during different checks (made by Expo CLI or
expo-doctor).We also tend to not accept ESLint related packages, since there is so many of configs and plugins, and they will clutter the directory.
Thank you for your reply. I will try to ignore eslint-config-expo in expo-doctor.
There was a problem hiding this comment.
We should not be checking for devDependencies in doctor, if we do, that's a bug, and please let us know!
You can also ignore the given packages via doctor config, see:
There was a problem hiding this comment.
We should not be checking for
devDependenciesin doctor, if we do, that's a bug, and please let us know!You can also ignore the given packages via
doctorconfig, see:
Thank you so much for telling me about this config. I'll go try it right away.
Minori-ty
changed the title
Simek
left a comment
Simek
left a comment
There was a problem hiding this comment.
Thanks for adding a new package to the directory! 👍
2 participants
📝 Why & how
add react-error-boundary to directory
✅ Checklist
react-native-libraries.jsonreact-native-libraries.json