add alternatives field checks for the new entries#2157
Merged
Conversation
Comment on lines
+126
to
+130
| if (!alternativesDataJson[alternative].unmaintained) { | ||
| console.error( | ||
| `${alternative} is not marked as unmaintained in the directory, so it cannot be defined as an alternative for the package.` | ||
| ); | ||
| return false; |
Contributor
There was a problem hiding this comment.
In your comment you explained
the alternatives should be placed in the unmaintained package entry [...] instead of [the new package entry]
but here, you're enforcing the opposite (that the alternatives in a new package entry point to unmaintained packages) 😅 @Simek
Member
Author
There was a problem hiding this comment.
Good catch, spotted that too and corrected in:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Why & how
We should validate the
alternativesarray entries for newly proposed packages, refs:@preeternal/react-native-cookie-manager#2155Add few checks to
validate-new-entries.tsscript which ensures the correctness ofalternativesarray.✅ Checklist