Include npm keywords in topic search#2251
Closed
brentvatne wants to merge 1 commit into
Closed
Conversation
Extract keywords from the npm registry response (via processTopics) and merge them into topicSearchString for search discoverability. A Set deduplicates against GitHub topics so each term is counted once.
Contributor
Author
|
nm I misunderstood the current approach |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Why & how
Libraries that lack GitHub repo topics (e.g.
expo-apple-targets) have no keyword-based search discoverability. The npm registry response includes akeywordsfield that's already typed (NpmRegistryCommonData.keywords) but never extracted.This PR extracts npm keywords during the registry fetch (processed through
processTopics()), adds them to thenpmtype, and merges them intotopicSearchStringalongside GitHub topics. ASetdeduplicates so each term is only counted once per library.✅ Checklist
bun scripts/validate-new-entriespassesSetdedup