Skip to content

Add react-native-barcode-qr-generator library entry#2327

Merged
Simek merged 3 commits intoreact-native-community:mainfrom
alicanov98:patch-1
Mar 31, 2026
Merged

Add react-native-barcode-qr-generator library entry#2327
Simek merged 3 commits intoreact-native-community:mainfrom
alicanov98:patch-1

Conversation

@alicanov98
Copy link
Copy Markdown
Contributor

@alicanov98 alicanov98 commented Mar 30, 2026

📝 Why & how

✅ Checklist

  • Added library to react-native-libraries.json
  • Updated library in react-native-libraries.json
  • Documented how you found or replicated the issue.
  • Explained how you fixed the issue or built the feature.
  • Described how to use or verify the change.

@alicanov98 alicanov98 closed this Mar 30, 2026
@alicanov98 alicanov98 reopened this Mar 30, 2026
@Simek
Copy link
Copy Markdown
Member

Simek commented Mar 30, 2026

Hey @alicanov98, thanks for adding new entry to the directory! 👍

I have fixed the JSON syntax error and cleanup up the entry, no we need to wait with merge until npm API returns correct response - it take some time since they properly register fresh packages, and return the download data.

More details, and API fetch link can be found in CI logs:

@Simek Simek merged commit a615443 into react-native-community:main Mar 31, 2026
2 checks passed
@alicanov98
Copy link
Copy Markdown
Contributor Author

alicanov98 commented Apr 1, 2026 via email

@Simek
Copy link
Copy Markdown
Member

Simek commented Apr 1, 2026

Hey @alicanov98, in this case the issue was trailing coma (after android flag) - JSON does not support those, it only valid in JSONC/JSON5.

The lint issue which popped up after fixing comma was caused by unnecessary multiline array split - Oxfmt (just like Prettier) have the line max length limit, if the array with URL does not exceed it, it should not be formatted into multiline.

If you have local checkout there are git hooks and scripts which validate and cleanup data entry for you automatically. You can also use bunx rn-directory CLI to submit new entries - it will create PR automatically on you behalf, a will ensure correct formatting.

@alicanov98
Copy link
Copy Markdown
Contributor Author

alicanov98 commented Apr 1, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants