Add react-native-barcode-qr-generator library entry#2327
Add react-native-barcode-qr-generator library entry#2327Simek merged 3 commits intoreact-native-community:mainfrom
Conversation
|
Hey @alicanov98, thanks for adding new entry to the directory! 👍 I have fixed the JSON syntax error and cleanup up the entry, no we need to wait with merge until npm API returns correct response - it take some time since they properly register fresh packages, and return the download data. More details, and API fetch link can be found in CI logs: |
|
Hello @Simek,
I’m having trouble understanding why I couldn’t identify and fix the root
cause of the issue. Could you please help me?
Bartosz Kaszubowski ***@***.***>, 31 Mar 2026 Sal, 14:09
tarihinde şunu yazdı:
… Merged #2327
<#2327> into main.
—
Reply to this email directly, view it on GitHub
<#2327?email_source=notifications&email_token=A4H6PK5MKWPJJKPRPTYFWIT4TOKL3A5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTENBQGY4TAOJXGA4TPJTSMVQXG33OU5WWK3TUNFXW5JLFOZSW45FMMZXW65DFOJPWG3DJMNVQ#event-24069097097>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4H6PK2XA3JJDGD7QEIGF3L4TOKL3AVCNFSM6AAAAACXGDP6H6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRUGA3DSMBZG4YDSNY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
.com>
|
|
Hey @alicanov98, in this case the issue was trailing coma (after The lint issue which popped up after fixing comma was caused by unnecessary multiline array split - Oxfmt (just like Prettier) have the line max length limit, if the array with URL does not exceed it, it should not be formatted into multiline. If you have local checkout there are git hooks and scripts which validate and cleanup data entry for you automatically. You can also use |
|
@Simek, thanks a lot for the detailed review and fixes! 🙏
Really appreciate you catching the JSON syntax issue and explaining the
npmPkg usage — that helped clarify things a lot. Also thanks for pointing
out the lint/formatting rules and the CLI tip, I’ll definitely use bunx
rn-directory for future submissions.
Thanks again for your time and support!
Bartosz Kaszubowski ***@***.***>, 1 Nis 2026 Çar, 15:03
tarihinde şunu yazdı:
… *Simek* left a comment (react-native-community/directory#2327)
<#2327?email_source=notifications&email_token=A4H6PK6FKWEWSDRDYCRVPTD4TTZRFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJWHEZDMOJQHE32M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4169269097>
Hey @alicanov98 <https://github.com/alicanov98>, in this case the issue
was trailing coma (after android flag) - JSON does not support those, it
only valid in JSONC/JSON5.
The lint issue which popped up after fixing comma was caused by
unnecessary multiline array split - Oxfmt (just like Prettier) have the
line max length limit, if the array with URL does not exceed it, it should
not be formatted into multiline.
If you have local checkout there are git hooks and scripts which validate
and cleanup data entry for you automatically. You can also use bunx
rn-directory CLI to submit new entries - it will create PR automatically
on you behalf, a will ensure correct formatting.
—
Reply to this email directly, view it on GitHub
<#2327?email_source=notifications&email_token=A4H6PK6FKWEWSDRDYCRVPTD4TTZRFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJWHEZDMOJQHE32M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4169269097>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4H6PK4GHPPXZ4F5SNNJOOL4TTZRFAVCNFSM6AAAAACXGDP6H6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCNRZGI3DSMBZG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
📝 Why & how
✅ Checklist
react-native-libraries.jsonreact-native-libraries.json