Skip to content

fix react-native-google-signin ios error#101

Merged
Simek merged 1 commit into
react-native-community:mainfrom
Kudo:@kudo/fix-google-signin-error
Jun 29, 2026
Merged

fix react-native-google-signin ios error#101
Simek merged 1 commit into
react-native-community:mainfrom
Kudo:@kudo/fix-google-signin-error

Conversation

@Kudo

@Kudo Kudo commented Jun 29, 2026

Copy link
Copy Markdown
Member

Why

fix nightly build error for react-native-google-signin

How

workaround per react-native-google-signin/google-signin#1517 and add the patch

Test Plan

build passed

@Kudo Kudo force-pushed the @kudo/fix-google-signin-error branch 3 times, most recently from c6b2d5b to 8f0d3a6 Compare June 29, 2026 19:31
@Kudo Kudo force-pushed the @kudo/fix-google-signin-error branch from 8f0d3a6 to d6a8d3a Compare June 29, 2026 19:32
@Kudo Kudo marked this pull request as ready for review June 29, 2026 19:48
@Kudo Kudo requested a review from cortinico June 29, 2026 19:48

@Simek Simek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @Kudo! 🙏

@Simek Simek merged commit 80d7d1a into react-native-community:main Jun 29, 2026
5 checks passed
target 'RNApp' do
config = use_native_modules!

+ pod 'AppCheckCore', '11.2.0'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to be fixed inside the library at any point or is it added in the README (or as a config plugin)? Asking as we're effectively making the job green here, but the nightly is broken for the average user no?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's not breaking from nightly. it affects current react-native version and expo sdk. google released a new AppCheckCore which is a transitive dep from the GoogleSignIn. someone opened react-native-google-signin/google-signin#1519 but that's for expo only. will wait @vonovak to decide what to move forward when he's back. i just workaround the problem here 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants