feat: persist completed diff progress#422
Closed
popsiclelmlm wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #413.
This persists the files marked as viewed in localStorage so progress survives a refresh or a later return to the same upgrade range. The storage key includes the package, language, and version range, and stored entries are pruned against the current diff so stale file IDs are ignored when diff contents change.
The change is scoped to the diff viewer progress state and does not add any backend/shared state.
Test Plan
yarn test --testPathPattern=completed-diffs-storage.spec.tsyarn lintyarn typecheckWhat are the steps to reproduce?
Checklist
README.md(if needed)