feat(android)!: remove deprecated positiveButtonLabel, negativeButtonLabel, neutralButtonLabel props (#1039)

Author: vonovak

README.md

@@ -568,31 +568,6 @@ Set the negative button label and text color.
 <RNDateTimePicker negativeButton={{label: 'Cancel', textColor: 'red'}} />
 ```
 
-#### `positiveButtonLabel` (`optional`, `Android only`, deprecated)
-
-Changes the label of the positive button.
-
-```js
-<RNDateTimePicker positiveButtonLabel="OK!" />
-```
-
-#### `negativeButtonLabel` (`optional`, `Android only`, deprecated)
-
-Changes the label of the negative button.
-
-```js
-<RNDateTimePicker negativeButtonLabel="Negative" />
-```
-
-#### `neutralButtonLabel` (`optional`, `Android only`, deprecated)
-
-Allows displaying neutral button on picker dialog.
-Pressing button can be observed in onChange handler as `event.type === 'neutralButtonPressed'`
-
-```js
-<RNDateTimePicker neutralButtonLabel="clear" />
-```
-
 #### `minuteInterval` (`optional`)
 
 The interval at which minutes can be selected.

src/DateTimePickerAndroid.android.js

@@ -42,9 +42,6 @@ function open(props: AndroidNativeProps) {
     positiveButton,
     negativeButton,
     neutralButton,
-    neutralButtonLabel,
-    positiveButtonLabel,
-    negativeButtonLabel,
     testID,
     firstDayOfWeek,
     title,
@@ -63,17 +60,14 @@ function open(props: AndroidNativeProps) {
     try {
       const dialogButtons = {
         positive: {
-          label: positiveButtonLabel,
           ...positiveButton,
           textColor: processColor(positiveButton?.textColor),
         },
         neutral: {
-          label: neutralButtonLabel,
           ...neutralButton,
           textColor: processColor(neutralButton?.textColor),
         },
         negative: {
-          label: negativeButtonLabel,
           ...negativeButton,
           textColor: processColor(negativeButton?.textColor),
         },

src/androidUtils.js

@@ -121,16 +121,6 @@ function validateAndroidProps(props: AndroidNativeProps) {
       !(display === ANDROID_DISPLAY.clock && mode === ANDROID_MODE.date),
     `display: ${display} and mode: ${mode} cannot be used together.`,
   );
-  if (
-    props?.positiveButtonLabel !== undefined ||
-    props?.negativeButtonLabel !== undefined ||
-    props?.neutralButtonLabel !== undefined
-  ) {
-    console.warn(
-      'positiveButtonLabel, negativeButtonLabel and neutralButtonLabel are deprecated.' +
-        'Use positive / negative / neutralButton prop instead.',
-    );
-  }
 }
 
 function validateMaterial3PropsNotUsed(props: AndroidNativeProps) {

src/datetimepicker.android.js

@@ -28,9 +28,6 @@ export default function RNDateTimePickerAndroid(
     positiveButton,
     negativeButton,
     neutralButton,
-    positiveButtonLabel,
-    negativeButtonLabel,
-    neutralButtonLabel,
     testID,
     firstDayOfWeek,
     title,
@@ -64,9 +61,6 @@ export default function RNDateTimePickerAndroid(
         positiveButton,
         negativeButton,
         neutralButton,
-        positiveButtonLabel,
-        negativeButtonLabel,
-        neutralButtonLabel,
         testID,
         firstDayOfWeek,
         title,

src/index.d.ts

@@ -165,18 +165,6 @@ export type AndroidNativeProps = Readonly<
       neutralButton?: ButtonType;
       negativeButton?: ButtonType;
 
-      /**
-       * @deprecated use neutralButton instead
-       * */
-      neutralButtonLabel?: string;
-      /**
-       * @deprecated use positiveButton instead
-       * */
-      positiveButtonLabel?: string;
-      /**
-       * @deprecated use negativeButton instead
-       * */
-      negativeButtonLabel?: string;
       /**
        * Sets the first day of the week shown in the calendar
        */

src/types.js

@@ -237,18 +237,6 @@ export type AndroidNativeProps = $ReadOnly<{|
   // Not supported in Material 3 pickers
   neutralButton?: ButtonType,
   negativeButton?: ButtonType,
-  /**
-   * @deprecated use neutralButton instead
-   * */
-  neutralButtonLabel?: string,
-  /**
-   * @deprecated use positiveButton instead
-   * */
-  positiveButtonLabel?: string,
-  /**
-   * @deprecated use negativeButton instead
-   * */
-  negativeButtonLabel?: string,
   /**
    * Sets the first day of the week shown in the calendar
    */