Skip to content

fix(android): correct long term access directory picker response #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vonovak merged 3 commits into from
May 5, 2025
Merged

fix(android): correct long term access directory picker response #823

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a124519
fix(android): unify bookmark status key across platforms
OldStager01 May 5, 2025
2c5e4e7
Apply suggestions from code review
vonovak May 5, 2025
6b030f8
Create flat-pumpkins-matter.md
vonovak May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...ment-picker/android/src/main/java/com/reactnativedocumentpicker/RNDocumentPickerModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,9 +218,9 @@ class RNDocumentPickerModule(reactContext: ReactApplicationContext) :
)
// TODO clarify if this should be done
// pickedFilesUriMap.remove(uriString)
result.putString("status", "success")
result.putString("bookmarkStatus", "success")
Comment thread
vonovak marked this conversation as resolved.
Outdated
} catch (e: Exception) {
result.putString("status", "error")
result.putString("bookmarkStatus", "error")
Comment thread
vonovak marked this conversation as resolved.
Outdated
result.putString("errorMessage", e.message ?: "Unknown error")
}
results.pushMap(result)
Expand Down Expand Up @@ -254,12 +254,12 @@ class RNDocumentPickerModule(reactContext: ReactApplicationContext) :
reactApplicationContext.contentResolver.takePersistableUriPermission(uri, takeFlags)
val encodedBookmark =
Base64.encodeToString(uri.toString().toByteArray(Charsets.UTF_8), Base64.DEFAULT)
map.putString("status", "success")
map.putString("bookmarkStatus", "success")
map.putString("bookmark", encodedBookmark)
} catch (e: Exception) {
val error =
e.localizedMessage ?: e.message ?: "Unknown error with takePersistableUriPermission"
map.putString("status", "error")
map.putString("bookmarkStatus", "error")
map.putString("bookmarkError", error)
}
}
Expand Down