Skip to content
This repository was archived by the owner on Feb 25, 2020. It is now read-only.

Commit d39b613

Browse files
committed
chore: upgrade react-navigation
1 parent d4e1153 commit d39b613

5 files changed

Lines changed: 28 additions & 24 deletions

File tree

example/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"react-native-unimodules": "~0.5.2",
2626
"react-native-web": "^0.11.4",
2727
"react-native-webview": "~5.12.0",
28-
"react-navigation": "^4.0.4",
28+
"react-navigation": "^4.0.5",
2929
"react-navigation-drawer": "^2.0.0",
3030
"react-navigation-tabs": "2.2.0"
3131
},

example/yarn.lock

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1261,10 +1261,10 @@
12611261
resolved "https://registry.yarnpkg.com/@react-native-community/masked-view/-/masked-view-0.1.1.tgz#dbcfc5ec08efbb02d4142dd9426c8d7a396829d7"
12621262
integrity sha512-EyJVSbarZkOPYq+zCZLx9apMcpwkX9HvH6R+6CeVL29q88kEFemnLO/IhmE4YX/0MfalsduI8eTi7fuQh/5VeA==
12631263

1264-
"@react-navigation/core@^3.5.0":
1265-
version "3.5.0"
1266-
resolved "https://registry.yarnpkg.com/@react-navigation/core/-/core-3.5.0.tgz#73d1a12448e2bd71855e0080b95a7f51ede0cd9e"
1267-
integrity sha512-NLm24lA51R8o8c+iFnwtN9elqRzm4OJ8f1qPBCUNIYW1sb8M5yCD53vRP0fRcPFpr/6Xzs2TJMsWnnebwFp0Rw==
1264+
"@react-navigation/core@^3.5.1":
1265+
version "3.5.1"
1266+
resolved "https://registry.yarnpkg.com/@react-navigation/core/-/core-3.5.1.tgz#7a2339fca3496979305fb3a8ab88c2ca8d8c214d"
1267+
integrity sha512-q7NyhWVYOhVIWqL2GZKa6G78YarXaVTTtOlSDkvy4ZIggo40wZzamlnrJRvsaQX46gsgw45FAWb5SriHh8o7eA==
12681268
dependencies:
12691269
hoist-non-react-statics "^3.3.0"
12701270
path-to-regexp "^1.7.0"
@@ -9451,12 +9451,12 @@ react-navigation-tabs@2.2.0:
94519451
react-lifecycles-compat "^3.0.4"
94529452
react-native-tab-view "^2.6.2"
94539453

9454-
react-navigation@^4.0.4:
9455-
version "4.0.4"
9456-
resolved "https://registry.yarnpkg.com/react-navigation/-/react-navigation-4.0.4.tgz#afa43c7183891d38708cf57f1d4394fed1d4c2ad"
9457-
integrity sha512-MZeVkYkFTKZobhrXMV3Hgeg0HHeokCrYsbxActVfO0n6zfzm0/La6EiC2mIHiwOymvb1ZygyFf90vryLUMEBNA==
9454+
react-navigation@^4.0.5:
9455+
version "4.0.5"
9456+
resolved "https://registry.yarnpkg.com/react-navigation/-/react-navigation-4.0.5.tgz#d4e16d9884cfd6bb2cda4d16e001227e2c859b46"
9457+
integrity sha512-VidRiSA2RvrgPlKs/7FNKV6pXEYXREtxiEl6m/Dmfb8x27amG6JRibzJC2mpWt4w0SAIGMUjHallRi3h9sIk0A==
94589458
dependencies:
9459-
"@react-navigation/core" "^3.5.0"
9459+
"@react-navigation/core" "^3.5.1"
94609460
"@react-navigation/native" "^3.6.2"
94619461

94629462
react-proxy@^1.1.7:

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
"react-native-gesture-handler": "^1.3.0",
6969
"react-native-reanimated": "^1.1.0",
7070
"react-native-screens": "^1.0.0-alpha.23",
71-
"react-navigation": "^4.0.4",
71+
"react-navigation": "^4.0.5",
7272
"react-test-renderer": "16.8.3",
7373
"release-it": "^12.3.2",
7474
"scheduler": "^0.14.0",
@@ -81,7 +81,7 @@
8181
"react-native-gesture-handler": "^1.0.0",
8282
"react-native-reanimated": "^1.3.0-alpha",
8383
"react-native-screens": "^1.0.0 || ^1.0.0-alpha",
84-
"react-navigation": "^4.0.4"
84+
"react-navigation": "^4.0.5"
8585
},
8686
"jest": {
8787
"preset": "react-native",

src/views/Stack/Stack.tsx

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,8 @@ const MaybeScreen = ({
102102
return <View {...rest} />;
103103
};
104104

105+
const FALLBACK_DESCRIPTOR = Object.freeze({ options: {} });
106+
105107
const { cond, eq } = Animated;
106108

107109
const ANIMATED_ONE = new Animated.Value(1);
@@ -163,19 +165,21 @@ export default class Stack extends React.Component<Props, State> {
163165
: undefined;
164166
const next = nextRoute ? progress[nextRoute.key] : undefined;
165167

168+
const oldScene = state.scenes[index];
166169
const scene = {
167170
route,
168171
previous: previousRoute,
169-
descriptor: props.descriptors[route.key],
172+
descriptor:
173+
props.descriptors[route.key] ||
174+
state.descriptors[route.key] ||
175+
(oldScene ? oldScene.descriptor : FALLBACK_DESCRIPTOR),
170176
progress: {
171177
current,
172178
next,
173179
previous,
174180
},
175181
};
176182

177-
const oldScene = state.scenes[index];
178-
179183
if (
180184
oldScene &&
181185
scene.route === oldScene.route &&

yarn.lock

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1155,10 +1155,10 @@
11551155
resolved "https://registry.yarnpkg.com/@react-native-community/masked-view/-/masked-view-0.1.1.tgz#dbcfc5ec08efbb02d4142dd9426c8d7a396829d7"
11561156
integrity sha512-EyJVSbarZkOPYq+zCZLx9apMcpwkX9HvH6R+6CeVL29q88kEFemnLO/IhmE4YX/0MfalsduI8eTi7fuQh/5VeA==
11571157

1158-
"@react-navigation/core@^3.5.0":
1159-
version "3.5.0"
1160-
resolved "https://registry.yarnpkg.com/@react-navigation/core/-/core-3.5.0.tgz#73d1a12448e2bd71855e0080b95a7f51ede0cd9e"
1161-
integrity sha512-NLm24lA51R8o8c+iFnwtN9elqRzm4OJ8f1qPBCUNIYW1sb8M5yCD53vRP0fRcPFpr/6Xzs2TJMsWnnebwFp0Rw==
1158+
"@react-navigation/core@^3.5.1":
1159+
version "3.5.1"
1160+
resolved "https://registry.yarnpkg.com/@react-navigation/core/-/core-3.5.1.tgz#7a2339fca3496979305fb3a8ab88c2ca8d8c214d"
1161+
integrity sha512-q7NyhWVYOhVIWqL2GZKa6G78YarXaVTTtOlSDkvy4ZIggo40wZzamlnrJRvsaQX46gsgw45FAWb5SriHh8o7eA==
11621162
dependencies:
11631163
hoist-non-react-statics "^3.3.0"
11641164
path-to-regexp "^1.7.0"
@@ -7333,12 +7333,12 @@ react-native@~0.59.8:
73337333
xmldoc "^0.4.0"
73347334
yargs "^9.0.0"
73357335

7336-
react-navigation@^4.0.4:
7337-
version "4.0.4"
7338-
resolved "https://registry.yarnpkg.com/react-navigation/-/react-navigation-4.0.4.tgz#afa43c7183891d38708cf57f1d4394fed1d4c2ad"
7339-
integrity sha512-MZeVkYkFTKZobhrXMV3Hgeg0HHeokCrYsbxActVfO0n6zfzm0/La6EiC2mIHiwOymvb1ZygyFf90vryLUMEBNA==
7336+
react-navigation@^4.0.5:
7337+
version "4.0.5"
7338+
resolved "https://registry.yarnpkg.com/react-navigation/-/react-navigation-4.0.5.tgz#d4e16d9884cfd6bb2cda4d16e001227e2c859b46"
7339+
integrity sha512-VidRiSA2RvrgPlKs/7FNKV6pXEYXREtxiEl6m/Dmfb8x27amG6JRibzJC2mpWt4w0SAIGMUjHallRi3h9sIk0A==
73407340
dependencies:
7341-
"@react-navigation/core" "^3.5.0"
7341+
"@react-navigation/core" "^3.5.1"
73427342
"@react-navigation/native" "^3.6.2"
73437343

73447344
react-proxy@^1.1.7:

0 commit comments

Comments
 (0)