feat(hr): Phase 138 — HR Succession Planning

Adds succession planning module with plans, candidates, policy, controller,
routes, React stubs, and 9 Pest feature tests (all passing).

https://claude.ai/code/session_01RdUGwo74JXChRCF88Yu27d

Author: claude

erp/app/Modules/HR/Http/Controllers/SuccessionPlanController.php

@@ -2,36 +2,56 @@
 
 namespace App\Modules\HR\Http\Controllers;
 
+use App\Http\Controllers\Controller;
+use App\Modules\HR\Models\Employee;
 use App\Modules\HR\Models\SuccessionPlan;
 use Illuminate\Http\RedirectResponse;
 use Illuminate\Http\Request;
 use Inertia\Inertia;
 use Inertia\Response;
 
-class SuccessionPlanController
+class SuccessionPlanController extends Controller
 {
-    public function index(): Response
+    public function index(Request $request): Response
     {
-        $plans = SuccessionPlan::with('currentHolder')
-            ->orderByDesc('created_at')
-            ->paginate(20);
+        $this->authorize('viewAny', SuccessionPlan::class);
 
-        return Inertia::render('HR/SuccessionPlans/Index', compact('plans'));
+        $query = SuccessionPlan::with('currentHolder')
+            ->orderByDesc('created_at');
+
+        if ($request->filled('status')) {
+            $query->where('status', $request->status);
+        }
+
+        if ($request->filled('department')) {
+            $query->where('department', $request->department);
+        }
+
+        $plans   = $query->paginate(15);
+        $filters = $request->only(['status', 'department']);
+
+        return Inertia::render('HR/SuccessionPlans/Index', compact('plans', 'filters'));
     }
 
     public function create(): Response
     {
-        return Inertia::render('HR/SuccessionPlans/Create');
+        $this->authorize('create', SuccessionPlan::class);
+
+        $employees = Employee::where('status', 'active')
+            ->orderBy('first_name')
+            ->get(['id', 'first_name', 'last_name']);
+
+        return Inertia::render('HR/SuccessionPlans/Create', compact('employees'));
     }
 
     public function store(Request $request): RedirectResponse
     {
+        $this->authorize('create', SuccessionPlan::class);
+
         $data = $request->validate([
-            'position_title'    => 'required|string|max:255',
-            'department'        => 'nullable|string|max:255',
-            'description'       => 'nullable|string',
-            'is_critical'       => 'nullable|boolean',
-            'current_holder_id' => 'nullable|exists:employees,id',
+            'position_title' => ['required', 'string'],
+            'department'     => ['nullable', 'string'],
+            'is_critical'    => ['nullable', 'boolean'],
         ]);
 
         $data['tenant_id']  = app('tenant')->id;
@@ -44,23 +64,34 @@ public function store(Request $request): RedirectResponse
 
     public function show(SuccessionPlan $successionPlan): Response
     {
-        $successionPlan->load('candidates.employee', 'currentHolder');
-        return Inertia::render('HR/SuccessionPlans/Show', ['plan' => $successionPlan]);
+        $this->authorize('view', $successionPlan);
+
+        $successionPlan->load(['currentHolder', 'candidates.employee']);
+
+        return Inertia::render('HR/SuccessionPlans/Show', compact('successionPlan'));
     }
 
     public function edit(SuccessionPlan $successionPlan): Response
     {
-        return Inertia::render('HR/SuccessionPlans/Edit', ['plan' => $successionPlan]);
+        $this->authorize('update', $successionPlan);
+
+        $employees = Employee::where('status', 'active')
+            ->orderBy('first_name')
+            ->get(['id', 'first_name', 'last_name']);
+
+        $successionPlan->load('currentHolder');
+
+        return Inertia::render('HR/SuccessionPlans/Edit', compact('successionPlan', 'employees'));
     }
 
     public function update(Request $request, SuccessionPlan $successionPlan): RedirectResponse
     {
+        $this->authorize('update', $successionPlan);
+
         $data = $request->validate([
-            'position_title'    => 'required|string|max:255',
-            'department'        => 'nullable|string|max:255',
-            'description'       => 'nullable|string',
-            'is_critical'       => 'nullable|boolean',
-            'current_holder_id' => 'nullable|exists:employees,id',
+            'position_title' => ['required', 'string'],
+            'department'     => ['nullable', 'string'],
+            'is_critical'    => ['nullable', 'boolean'],
         ]);
 
         $successionPlan->update($data);
@@ -70,19 +101,28 @@ public function update(Request $request, SuccessionPlan $successionPlan): Redire
 
     public function destroy(SuccessionPlan $successionPlan): RedirectResponse
     {
+        $this->authorize('delete', $successionPlan);
+
         $successionPlan->delete();
+
         return redirect()->route('hr.succession-plans.index');
     }
 
     public function complete(SuccessionPlan $successionPlan): RedirectResponse
     {
+        $this->authorize('complete', $successionPlan);
+
         $successionPlan->complete();
+
         return redirect()->route('hr.succession-plans.index');
     }
 
     public function deactivate(SuccessionPlan $successionPlan): RedirectResponse
     {
+        $this->authorize('deactivate', $successionPlan);
+
         $successionPlan->deactivate();
+
         return redirect()->route('hr.succession-plans.index');
     }
 }

erp/app/Modules/HR/Policies/SuccessionPlanPolicy.php

@@ -7,11 +7,38 @@
 
 class SuccessionPlanPolicy
 {
-    public function viewAny(User $user): bool { return $user->hasPermissionTo('hr.view'); }
-    public function view(User $user, SuccessionPlan $plan): bool { return $user->hasPermissionTo('hr.view'); }
-    public function create(User $user): bool { return $user->hasPermissionTo('hr.create'); }
-    public function update(User $user, SuccessionPlan $plan): bool { return $user->hasPermissionTo('hr.create'); }
-    public function delete(User $user, SuccessionPlan $plan): bool { return $user->hasPermissionTo('hr.delete'); }
-    public function complete(User $user, SuccessionPlan $plan): bool { return $user->hasPermissionTo('hr.create'); }
-    public function deactivate(User $user, SuccessionPlan $plan): bool { return $user->hasPermissionTo('hr.create'); }
+    public function viewAny(User $user): bool
+    {
+        return $user->can('hr.view');
+    }
+
+    public function view(User $user, SuccessionPlan $successionPlan): bool
+    {
+        return $user->can('hr.view');
+    }
+
+    public function create(User $user): bool
+    {
+        return $user->can('hr.create');
+    }
+
+    public function update(User $user, SuccessionPlan $successionPlan): bool
+    {
+        return $user->can('hr.create');
+    }
+
+    public function complete(User $user, SuccessionPlan $successionPlan): bool
+    {
+        return $user->can('hr.create');
+    }
+
+    public function deactivate(User $user, SuccessionPlan $successionPlan): bool
+    {
+        return $user->can('hr.create');
+    }
+
+    public function delete(User $user, SuccessionPlan $successionPlan): bool
+    {
+        return $user->can('hr.delete');
+    }
 }