metro-file-map: Make plugin.bulkUpdate synchronous

Summary:
There's no need for this to be async and making it synchronous simplifies some upcoming work

Changelog: Internal

Reviewed By: vzaidman

Differential Revision: D92007667

fbshipit-source-id: 7e4f764d5750de45041b189e5518e5c081ee8cf4

Author: robhogan

packages/metro-file-map/src/cache/__tests__/DiskCacheManager-test.js

@@ -105,7 +105,7 @@ describe('cacheManager', () => {
     let pluginCacheKey = 'foo';
     const plugin: FileMapPlugin<> = {
       name: 'foo',
-      async bulkUpdate() {},
+      bulkUpdate() {},
       async initialize() {},
       assertValid() {},
       getSerializableSnapshot() {

packages/metro-file-map/src/flow-types.js

@@ -213,7 +213,7 @@ export interface FileMapPlugin<
     initOptions: FileMapPluginInitOptions<SerializableState, PerFileData>,
   ): Promise<void>;
   assertValid(): void;
-  bulkUpdate(delta: FileMapDelta<?PerFileData>): Promise<void>;
+  bulkUpdate(delta: FileMapDelta<?PerFileData>): void;
   getSerializableSnapshot(): SerializableState;
   onRemovedFile(relativeFilePath: string, pluginData: ?PerFileData): void;
   onNewOrModifiedFile(relativeFilePath: string, pluginData: ?PerFileData): void;

packages/metro-file-map/src/index.js

@@ -667,21 +667,16 @@ export default class FileMap extends EventEmitter {
     this.#startupPerfLogger?.point('applyFileDelta_add_end');
 
     this.#startupPerfLogger?.point('applyFileDelta_updatePlugins_start');
-
-    await Promise.all([
-      plugins.map(({plugin, dataIdx}) => {
-        const mapFn: (
-          [CanonicalPath, FileMetadata],
-        ) => [CanonicalPath, unknown] =
-          dataIdx != null
-            ? ([relativePath, fileData]) => [relativePath, fileData[dataIdx]]
-            : ([relativePath, fileData]) => [relativePath, null];
-        return plugin.bulkUpdate({
-          addedOrModified: mapIterator(changedFiles.entries(), mapFn),
-          removed: mapIterator(removed.values(), mapFn),
-        });
-      }),
-    ]);
+    plugins.forEach(({plugin, dataIdx}) => {
+      const mapFn: ([CanonicalPath, FileMetadata]) => [CanonicalPath, unknown] =
+        dataIdx != null
+          ? ([relativePath, fileData]) => [relativePath, fileData[dataIdx]]
+          : ([relativePath, fileData]) => [relativePath, null];
+      plugin.bulkUpdate({
+        addedOrModified: mapIterator(changedFiles.entries(), mapFn),
+        removed: mapIterator(removed.values(), mapFn),
+      });
+    });
     this.#startupPerfLogger?.point('applyFileDelta_updatePlugins_end');
     this.#startupPerfLogger?.point('applyFileDelta_end');
   }

packages/metro-file-map/src/plugins/DependencyPlugin.js

@@ -64,7 +64,7 @@ export default class DependencyPlugin
     return null;
   }
 
-  async bulkUpdate(delta: FileMapDelta<?ReadonlyArray<string>>): Promise<void> {
+  bulkUpdate(delta: FileMapDelta<?ReadonlyArray<string>>): void {
     // No-op: Worker already populated plugin data
     // Plugin data is write-only from worker
   }

packages/metro-file-map/src/plugins/HastePlugin.js

@@ -237,7 +237,7 @@ export default class HastePlugin
     );
   }
 
-  async bulkUpdate(delta: FileMapDelta<?string>): Promise<void> {
+  bulkUpdate(delta: FileMapDelta<?string>): void {
     // Process removals first so that moves aren't treated as duplicates.
     for (const [normalPath, maybeHasteId] of delta.removed) {
       this.onRemovedFile(normalPath, maybeHasteId);

packages/metro-file-map/src/plugins/MockPlugin.js

@@ -79,7 +79,7 @@ export default class MockPlugin
       this.#raw = pluginState;
     } else {
       // Otherwise, traverse all files to rebuild
-      await this.bulkUpdate({
+      this.bulkUpdate({
         addedOrModified: [
           ...files.fileIterator({
             includeNodeModules: false,
@@ -102,7 +102,7 @@ export default class MockPlugin
     );
   }
 
-  async bulkUpdate(delta: FileMapDelta<>): Promise<void> {
+  bulkUpdate(delta: FileMapDelta<>): void {
     // Process removals first so that moves aren't treated as duplicates.
     for (const [relativeFilePath] of delta.removed) {
       this.onRemovedFile(relativeFilePath);

packages/metro-file-map/src/plugins/haste/__tests__/HastePlugin-test.js

@@ -141,11 +141,11 @@ describe.each([['win32'], ['posix']])('HastePlugin on %s', platform => {
       expect(hasteMap.getModule('Bar')).not.toBeNull();
     });
 
-    test('fixes duplicates, adds and removes modules', async () => {
+    test('fixes duplicates, adds and removes modules', () => {
       expect(() => hasteMap.getModule('Duplicate')).toThrow(
         DuplicateHasteCandidatesError,
       );
-      await hasteMap.bulkUpdate({
+      hasteMap.bulkUpdate({
         removed: [
           [p('project/Duplicate.js'), 'Duplicate'],
           [p('project/Foo.js'), 'NameForFoo'],

packages/metro-file-map/types/flow-types.d.ts

@@ -176,9 +176,7 @@ export interface FileMapPlugin<
     initOptions: FileMapPluginInitOptions<SerializableState, PerFileData>,
   ): Promise<void>;
   assertValid(): void;
-  bulkUpdate(
-    delta: FileMapDelta<null | undefined | PerFileData>,
-  ): Promise<void>;
+  bulkUpdate(delta: FileMapDelta<null | undefined | PerFileData>): void;
   getSerializableSnapshot(): SerializableState;
   onRemovedFile(
     relativeFilePath: string,

packages/metro-file-map/types/plugins/DependencyPlugin.d.ts

@@ -34,7 +34,7 @@ declare class DependencyPlugin
   getSerializableSnapshot(): null;
   bulkUpdate(
     delta: FileMapDelta<null | undefined | ReadonlyArray<string>>,
-  ): Promise<void>;
+  ): void;
   onNewOrModifiedFile(
     relativeFilePath: string,
     pluginData: null | undefined | ReadonlyArray<string>,

packages/metro-file-map/types/plugins/HastePlugin.d.ts

@@ -52,7 +52,7 @@ declare class HastePlugin
     platform: null | undefined | string,
     _supportsNativePlatform?: null | undefined | boolean,
   ): null | undefined | Path;
-  bulkUpdate(delta: FileMapDelta<null | undefined | string>): Promise<void>;
+  bulkUpdate(delta: FileMapDelta<null | undefined | string>): void;
   onNewOrModifiedFile(
     relativeFilePath: string,
     id: null | undefined | string,