Manually fix a 5 more files 11/n

Summary:
We are transforming the following utility types to be more consistent with typescript and better AI integration:

* `$NonMaybeType` -> `NonNullable`
* `$ReadOnly` -> `Readonly`
* `$ReadOnlyArray` -> `ReadonlyArray`
* `$ReadOnlyMap` -> `ReadonlyMap`
* `$ReadOnlySet` -> `ReadonlySet`
* `$Keys` -> `keyof`
* `$Values` -> `Values`
* `mixed` -> `unknown`

See details in https://fb.workplace.com/groups/flowlang/permalink/1837907750148213/.

Reviewed By: SamChou19815

Differential Revision: D91148085

fbshipit-source-id: f6928c08fd2c5839fa91d526b025457393e9bd4a

Author: marcoww6

packages/metro-file-map/src/lib/dependencyExtractor.js

@@ -22,18 +22,15 @@ const RIGHT_PARENTHESIS = '\\)';
 const WHITESPACE = '\\s*';
 const OPTIONAL_COMMA = '(:?,\\s*)?';
 
-function createRegExp(
-  parts /*: $ReadOnlyArray<string> */,
-  flags /*: string */,
-) {
+function createRegExp(parts /*: ReadonlyArray<string> */, flags /*: string */) {
   return new RegExp(parts.join(''), flags);
 }
 
-function alternatives(...parts /*: $ReadOnlyArray<string> */) {
+function alternatives(...parts /*: ReadonlyArray<string> */) {
   return `(?:${parts.join('|')})`;
 }
 
-function functionCallStart(...names /*: $ReadOnlyArray<string> */) {
+function functionCallStart(...names /*: ReadonlyArray<string> */) {
   return [
     NOT_A_DOT,
     WORD_SEPARATOR,

packages/metro-file-map/src/plugins/haste/worker.js

@@ -22,11 +22,11 @@ import type {MetadataWorker, WorkerMessage, V8Serializable} from '../../flow-typ
 const PACKAGE_JSON = path.sep + 'package.json';
 
 module.exports = class Worker /*:: implements MetadataWorker */ {
-  /*:: + */ #hasteImpl /*: ?$ReadOnly<{getHasteName: string => ?string}>  */ =
+  /*:: + */ #hasteImpl /*: ?Readonly<{getHasteName: string => ?string}>  */ =
     null;
 
   constructor(
-    {hasteImplModulePath} /*: $ReadOnly<{hasteImplModulePath: ?string}> */,
+    {hasteImplModulePath} /*: Readonly<{hasteImplModulePath: ?string}> */,
   ) {
     if (hasteImplModulePath != null) {
       // $FlowFixMe[unsupported-syntax] - dynamic require
@@ -36,7 +36,7 @@ module.exports = class Worker /*:: implements MetadataWorker */ {
 
   processFile(
     data /*: WorkerMessage */,
-    utils /*: $ReadOnly<{getContent: () => Buffer }> */,
+    utils /*: Readonly<{getContent: () => Buffer }> */,
   ) /*: V8Serializable */ {
     let hasteName /*: string | null */ = null;
     const {filePath} = data;

packages/metro-file-map/src/worker.js

@@ -33,7 +33,7 @@ function sha1hex(content /*: string | Buffer */) /*: string */ {
 }
 
 class Worker {
-  #plugins /*: $ReadOnlyArray<MetadataWorker> */;
+  #plugins /*: ReadonlyArray<MetadataWorker> */;
 
   constructor({plugins = []} /*: WorkerSetupArgs */) {
     this.#plugins = plugins.map(({modulePath, setupArgs}) => {

packages/metro-file-map/src/workerExclusionList.js

@@ -23,7 +23,7 @@
 
 'use strict';
 
-const extensions /*: $ReadOnlySet<string> */ = new Set([
+const extensions /*: ReadonlySet<string> */ = new Set([
   // JSONs are never haste modules, except for "package.json", which is handled.
   '.json',
 

scripts/jestFilter.js

@@ -55,7 +55,7 @@ if (process.env.NIGHTLY_TESTS_NO_LOCKFILE != null) {
 }
 
 module.exports = (
-  absoluteTestPaths /*: $ReadOnlyArray<string> */,
+  absoluteTestPaths /*: ReadonlyArray<string> */,
 ) /*: {filtered: Array<{test: string}>}*/ => {
   const skippedPathsSet = new Set(
     SKIPPED_PATHS.map(relativePath =>