Skip to content

Commit 0f401ca

Browse files
committed
allow parsing stack traces that end with "skipping x frames"
1 parent 3b58e23 commit 0f401ca

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

front_end/panels/console/ErrorStackParser.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,11 @@ export type SpecialHermesStackTraceFrameTypes =
2727
// for the frame so that a debugger could stitch together a
2828
// hybrid cross-language call stack
2929
'native' |
30+
// e.g "(eval:1:2)"- Seem to be reported when there's a
31+
// ReferenceError or TypeError during the initial bundle code execution.
32+
// TODO: Understand exactly where these originate from and what further work
33+
// should be done in regards to them
34+
'eval' |
3035
// e.g "(:3:4)"- Frames with empty url
3136
// TODO: Seems to be happening due to a bug that needs to be investigated
3237
// and produce an actual script URL instead
@@ -44,6 +49,10 @@ function getSpecialHermesFrameBasedOnURL(url: string): SpecialHermesStackTraceFr
4449
return 'native';
4550
}
4651

52+
if (url === 'eval') {
53+
return 'eval';
54+
}
55+
4756
if (url === '') {
4857
return 'empty url';
4958
}

0 commit comments

Comments
 (0)