Cleanup

Author: sbuggay

front_end/panels/timeline/TimelinePanel.ts

@@ -464,11 +464,6 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
    */
   #restoreSidebarVisibilityOnTraceLoad = false;
 
-  /**
-   * Store React Native platform metadata (Android, iOS, etc.)
-   */
-  #platformMetadata: Protocol.ReactNativeApplication.MetadataUpdatedEvent | null = null;
-
   /**
    * Used to track an aria announcement that we need to alert for
    * screen-readers. We track these because we debounce announcements to not
@@ -720,19 +715,13 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
             model.addEventListener(
               SDK.ReactNativeApplicationModel.Events.METADATA_UPDATED,
               (event: Common.EventTarget.EventTargetEvent<Protocol.ReactNativeApplication.MetadataUpdatedEvent>) => {
-                this.#platformMetadata = event.data;
-                if (this.#platformMetadata.platform === 'android') {
+                if (event.data.platform === 'android') {
                   this.showScreenshotsToolbarCheckbox?.setVisible(true);
                 }
               }
             );
             model.addEventListener(
               SDK.ReactNativeApplicationModel.Events.TRACE_REQUESTED, () => this.rnPrepareForTraceCapturedInBackground());
-
-            // Check if cached metadata is already available
-            if (model.metadataCached) {
-              this.#platformMetadata = model.metadataCached;
-            }
           },
           modelRemoved: (_model: SDK.ReactNativeApplicationModel.ReactNativeApplicationModel) => {},
         },
@@ -1211,6 +1200,9 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
     if (!isNode && !isReactNative) {
       this.showScreenshotsToolbarCheckbox =
           this.createSettingCheckbox(this.showScreenshotsSetting, i18nString(UIStrings.captureScreenshots));
+
+      // Hide this for now, this is to solve a timing problem with getting the platform metadata.
+      // This will be set back to visible only on Android.
       this.showScreenshotsToolbarCheckbox.setVisible(false);
       this.panelToolbar.appendToolbarItem(this.showScreenshotsToolbarCheckbox);
     }
@@ -1409,13 +1401,6 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
     this.timelinePane.element.appendChild(this.fileSelectorElement);
   }
 
-  /**
-   * Helper method to check if the platform is Android
-   */
-  #isAndroid(): boolean {
-    return this.#platformMetadata?.platform === 'Android';
-  }
-
   private contextMenu(event: Event): void {
     // Do not show this Context menu on FlameChart entries because we have a different context menu for FlameChart entries
     const mouseEvent = (event as MouseEvent);