Skip to content

Commit 771f0d3

Browse files
committed
prevent stack trace entries in console UI from being inline so a new line is always added between them and other printed elements
1 parent a7e4f59 commit 771f0d3

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

front_end/panels/console/ConsoleViewMessage.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -989,7 +989,7 @@ export class ConsoleViewMessage implements ConsoleViewportElement {
989989
// The Exceptiondetails include script IDs for stack frames, which allows more accurate
990990
// linking.
991991
const formatErrorStack =
992-
async(errorObj: SDK.RemoteObject.RemoteObject, includeCausedByPrefix = false): Promise<void> => {
992+
async(errorObj: SDK.RemoteObject.RemoteObject, includeCausedByPrefix: boolean): Promise<void> => {
993993
const error = SDK.RemoteObject.RemoteError.objectAsError(errorObj);
994994
const [details, cause] = await Promise.all([error.exceptionDetails(), error.cause()]);
995995
let errorElement = this.tryFormatAsError(error.errorStack, details);
@@ -1015,7 +1015,7 @@ export class ConsoleViewMessage implements ConsoleViewportElement {
10151015
}
10161016
};
10171017

1018-
this.#formatErrorStackPromiseForTest = formatErrorStack(output);
1018+
this.#formatErrorStackPromiseForTest = formatErrorStack(output, /* includeCausedByPrefix */ false);
10191019

10201020
return result;
10211021
}

front_end/panels/console/consoleView.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,7 @@
414414
align-items: stretch;
415415

416416
&:has(div > .stack-preview-container.show-hidden-rows) {
417-
--display-ignored-formatted-stack-frame: inherit;
417+
--display-ignored-formatted-stack-frame: block;
418418
}
419419

420420
&:has(.formatted-stack-frame .ignore-list-link):has(.formatted-stack-frame .devtools-link:not(.ignore-list-link)) {

0 commit comments

Comments
 (0)