Skip to content

Commit 977d403

Browse files
committed
Cleanup experiment
1 parent 93152ea commit 977d403

6 files changed

Lines changed: 13 additions & 7 deletions

File tree

front_end/core/host/UserMetrics.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -985,11 +985,10 @@ export enum DevtoolsExperiments {
985985
'timeline-alternative-navigation' = 104,
986986
// 106 was historically used [https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6230097]
987987
// next experiment should be 107
988-
'timeline-frames' = 108,
989988
/* eslint-enable @typescript-eslint/naming-convention */
990989

991990
// Increment this when new experiments are added.
992-
MAX_VALUE = 108,
991+
MAX_VALUE = 106,
993992
}
994993

995994
// Update DevToolsIssuesPanelIssueExpanded from tools/metrics/histograms/enums.xml if new enum is added.

front_end/core/rn_experiments/experimentsImpl.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -198,3 +198,10 @@ Instance.register({
198198
unstable: true,
199199
enabledByDefault: () => false,
200200
});
201+
202+
Instance.register({
203+
name: RNExperimentName.ENABLE_TIMELINE_FRAMES,
204+
title: 'Enable performance frames track',
205+
unstable: true,
206+
enabledByDefault: () => globalThis.enableTimelineFrames ?? false,
207+
});

front_end/core/root/Runtime.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -307,6 +307,7 @@ export enum RNExperimentName {
307307
JS_HEAP_PROFILER_ENABLE = 'js-heap-profiler-enable',
308308
ENABLE_PERFORMANCE_PANEL = 'enable-performance-panel',
309309
ENABLE_NETWORK_PANEL = 'enable-network-panel',
310+
ENABLE_TIMELINE_FRAMES = 'enable-timeline-frames',
310311
}
311312

312313
export enum ConditionName {
@@ -332,7 +333,6 @@ export const enum ExperimentName {
332333
TIMELINE_DEBUG_MODE = 'timeline-debug-mode',
333334
TIMELINE_ENHANCED_TRACES = 'timeline-enhanced-traces',
334335
TIMELINE_COMPILED_SOURCES = 'timeline-compiled-sources',
335-
TIMELINE_FRAMES = 'timeline-frames',
336336
TIMELINE_EXPERIMENTAL_INSIGHTS = 'timeline-experimental-insights',
337337
TIMELINE_DIM_UNRELATED_EVENTS = 'timeline-dim-unrelated-events',
338338
TIMELINE_ALTERNATIVE_NAVIGATION = 'timeline-alternative-navigation',
@@ -344,6 +344,7 @@ export const enum ExperimentName {
344344
NOT_REACT_NATIVE_SPECIFIC_UI = '!' + RNExperimentName.REACT_NATIVE_SPECIFIC_UI,
345345
ENABLE_PERFORMANCE_PANEL = RNExperimentName.ENABLE_PERFORMANCE_PANEL,
346346
ENABLE_NETWORK_PANEL = RNExperimentName.ENABLE_NETWORK_PANEL,
347+
ENABLE_TIMELINE_FRAMES = RNExperimentName.ENABLE_TIMELINE_FRAMES,
347348
}
348349

349350
export enum GenAiEnterprisePolicyValue {

front_end/entrypoints/main/MainImpl.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -301,10 +301,8 @@ export class MainImpl {
301301
Root.Runtime.experiments.register(
302302
Root.Runtime.ExperimentName.TIMELINE_DEBUG_MODE,
303303
'Performance panel: Enable debug mode (trace event details, etc)', true);
304-
Root.Runtime.experiments.register(
305-
Root.Runtime.ExperimentName.TIMELINE_FRAMES, 'Performance panel: Enable frames track', true);
306304

307-
// Debugging
305+
// Debugging
308306
Root.Runtime.experiments.register('instrumentation-breakpoints', 'Enable instrumentation breakpoints', true);
309307
Root.Runtime.experiments.register('use-source-map-scopes', 'Use scope information from source maps', true);
310308

front_end/global_typings/react_native.d.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ declare global {
1616
// eslint-disable-next-line no-var
1717
var enableDisplayingFullDisconnectedReason: boolean|undefined;
1818
// eslint-disable-next-line no-var
19+
var enableTimelineFrames: boolean|undefined;
20+
// eslint-disable-next-line no-var
1921
var reactNativeOpenInEditorButtonImage: string|undefined;
2022
// eslint-disable-next-line no-var,@typescript-eslint/naming-convention
2123
var FB_ONLY__reactNativeFeedbackLink: string|undefined;

front_end/ui/visual_logging/KnownContextValues.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3495,7 +3495,6 @@ export const knownContextValues = new Set([
34953495
'time',
34963496
'timeline',
34973497
'timeline-alternative-navigation',
3498-
'timeline-frames',
34993498
'timeline-capture-layers-and-pictures',
35003499
'timeline-capture-selector-stats',
35013500
'timeline-compiled-sources',

0 commit comments

Comments
 (0)