allow parsing stack traces that end with "skipping x frames"

Author: vzaidman

front_end/panels/console/ErrorStackParser.ts

@@ -21,30 +21,35 @@ export interface ParsedErrorFrame {
   };
 }
 
-export type SpecialHermesStackTraceFrameTypes = 'native' | 'address at' | 'empty url';
+export type SpecialHermesStackTraceFrameTypes =
+  // functions implemented in c++.
+  // TODO: these might be enhanced to include the C++ loc for the frame
+  // so that a debugger could stitch together a hybrid cross-language call stack
+  'native' |
+  // frames with empty url
+  // TODO: these seem to be happening due to a bug that needs to be investigated
+  // and produce an actual script URL instead
+  'address at' |
+  // frames pointing to a bytecode locations
+  // TODO: these could be symbolicated and link to source files with the help of
+  // a bytecode source maps once they are available.
+  'empty url' |
+  // frames collepsed in the middle of a stack trace for very long stack traces
+  'skipping x frames';
 
 function getSpecialHermesStackTraceFrameType({
     url,
 }: {
   url: Platform.DevToolsPath.UrlString,
 }): SpecialHermesStackTraceFrameTypes | null {
-  // functions implemented in c++.
-  // TODO: these might be enhanced to include the C++ loc for the frame
-  // so that a debugger could stitch together a hybrid cross-language call stack
   if (url === 'native') {
     return 'native';
   }
 
-  // frames with empty url
-  // TODO: these seem to be happening due to a bug that needs to be investigated
-  // and produce an actual script URL instead
   if (url === '') {
     return 'empty url';
   }
 
-  // frames pointing to a bytecode locations
-  // TODO: these could be symbolicated and link to source files with the help of
-  // a bytecode source maps once they are available.
   if (url.startsWith?.('address at ')) {
     return 'address at';
   }
@@ -77,6 +82,16 @@ export function parseSourcePositionsFromErrorStack(
     const match = /^\s*at\s(async\s)?/.exec(line);
     if (!match) {
       if (linkInfos.length && linkInfos[linkInfos.length - 1].isCallFrame) {
+        if (/^\s*... skipping \d+ frames$/.exec(line)) {
+          if (!linkInfos[linkInfos.length - 1].link) {
+            // Combine builtin frames.
+            linkInfos[linkInfos.length - 1].line += `\n${line}`;
+          } else {
+            linkInfos.push({line, isCallFrame: false});
+          }
+          specialHermesFramesParsed.add('skipping x frames');
+          continue;
+        }
         Host.rnPerfMetrics.stackTraceSymbolicationFailed(stack, line, '"at (url)" not found');
         return null;
       }