Skip to content

feat(font): Adding Stylistics As New FontVariant Values #3272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gedeagas wants to merge 2 commits into from
Closed

feat(font): Adding Stylistics As New FontVariant Values #3272

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
155e532
feat(font): Adding Stylistics As New Variant Values
gedeagas Aug 20, 2022
45b49be
fix(fontVariant): array of enum
gedeagas Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions docs/text-style-props.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,9 +405,29 @@ Set to `false` to remove extra font padding intended to make space for certain a

### `fontVariant`

| Type | Default |
| ---------------------------------------------------------------------------------------------------------- | ------- |
| array of enum(`'small-caps'`, `'oldstyle-nums'`, `'lining-nums'`, `'tabular-nums'`, `'proportional-nums'`) | `[]` |
| Type | Default |
| ---- | ------- |

| array of enum(`'small-caps'`, `'oldstyle-nums'`, `'lining-nums'`, `'tabular-nums'`, `'proportional-nums' `,`'stylistic-one'`,
, `'stylistic-two'`
, `'stylistic-three'`
, `'stylistic-four'`
, `'stylistic-five'`
, `'stylistic-six'`
, `'stylistic-seven'`
, `'stylistic-eight'`
, `'stylistic-nine'`
, `'stylistic-ten'`
, `'stylistic-eleven'`
, `'stylistic-twelve'`
, `'stylistic-thirteen'`
, `'stylistic-fourteen'`
, `'stylistic-fifteen'`
, `'stylistic-sixteen'`
, `'stylistic-seventeen'`
, `'stylistic-eighteen'`
, `'stylistic-nineteen'`
, `'stylistic-twenty'`) | `[]` |

@Simek Simek Sep 6, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| array of enum(`'small-caps'`, `'oldstyle-nums'`, `'lining-nums'`, `'tabular-nums'`, `'proportional-nums' `,`'stylistic-one'`,
, `'stylistic-two'`
, `'stylistic-three'`
, `'stylistic-four'`
, `'stylistic-five'`
, `'stylistic-six'`
, `'stylistic-seven'`
, `'stylistic-eight'`
, `'stylistic-nine'`
, `'stylistic-ten'`
, `'stylistic-eleven'`
, `'stylistic-twelve'`
, `'stylistic-thirteen'`
, `'stylistic-fourteen'`
, `'stylistic-fifteen'`
, `'stylistic-sixteen'`
, `'stylistic-seventeen'`
, `'stylistic-eighteen'`
, `'stylistic-nineteen'`
, `'stylistic-twenty'`) | `[]` |
| array of enum(`'small-caps'`, `'oldstyle-nums'`, `'lining-nums'`, `'tabular-nums'`, `'proportional-nums' `,`'stylistic-one'`, `'stylistic-two'`, `'stylistic-three'`, `'stylistic-four'`, `'stylistic-five'`, `'stylistic-six'`, `'stylistic-seven'`, `'stylistic-eight'`, `'stylistic-nine'`, `'stylistic-ten'`, `'stylistic-eleven'`, `'stylistic-twelve'`, `'stylistic-thirteen'`, `'stylistic-fourteen'`, `'stylistic-fifteen'`, `'stylistic-sixteen'`, `'stylistic-seventeen'`, `'stylistic-eighteen'`, `'stylistic-nineteen'`, `'stylistic-twenty'`) | `[]` |

Unfortunately, making table row multiline breaks the MD renderer.

Screenshot 2022-09-06 112431

@gedeagas gedeagas Sep 6, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, Thank you for the feedback @Simek

@Simek Simek Sep 6, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table still appears broken after the deploy with the suggested changes, so it looks like I need to checkout out it locally to looks at it and fix it. 😅 Maybe you would like to give it a try @gedeagas ?

@gedeagas gedeagas Sep 6, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, let me check again. sorry for the inconvenience

@Simek Simek Sep 23, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it looks like the table is still displaying incorrectly. 🤔


---

Expand Down