Skip to content

Commit 01d6dd5

Browse files
Martín Bigiograbbou
authored andcommitted
Avoid clearing out factory on DEV mode
Summary: grabbou pointed out this issue. We recently started cleaning out the factory function after module are required to save some memory. This broke HMR on some edge cases because sometimes the factory function may need to be re-executed. This PR just wraps the optimization into `__DEV__` to make sure we don't use it while developing. Closes #7568 Differential Revision: D3305120 Pulled By: martinbigio fbshipit-source-id: 741cffbb327d118f0bd0ec34dc1af53d4f94880e
1 parent f5b79fd commit 01d6dd5

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

  • packager/react-packager/src/Resolver/polyfills

packager/react-packager/src/Resolver/polyfills/require.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,11 @@ function loadModuleImplementation(moduleId, module) {
9898
// keep args in sync with with defineModuleCode in
9999
// packager/react-packager/src/Resolver/index.js
100100
factory(global, require, moduleObject, exports);
101-
module.factory = undefined;
101+
102+
// avoid removing factory in DEV mode as it breaks HMR
103+
if (!__DEV__) {
104+
module.factory = undefined;
105+
}
102106

103107
if (__DEV__) {
104108
Systrace.endEvent();

0 commit comments

Comments
 (0)